Apply suggestions from code review

Signed-off-by: Bart Smykla <bartek@smykla.com>
kumahq · Jul 5, 2023 · 28b61c2 · 28b61c2
1 parent 2968975
commit 28b61c2
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -40,10 +40,10 @@ jobs:
           max_timeout: 1200
       - name: link checker
         run: |
-          `go env GOPATH`/bin/muffet ${URL} --buffer-size 8192  --exclude https://twitter.com --max-connections-per-host=8 --exclude 127.0.0.1 --exclude 'https://github.com/kumahq/kuma/pull' --exclude 'https://github.com/spiffe/spiffe/blob/main/standards/X509-SVID.md.*' --rate-limit 50 --timeout 60
+          $(go env GOPATH)/bin/muffet ${URL} --buffer-size 8192  --exclude https://twitter.com --max-connections-per-host=8 --exclude 127.0.0.1 --exclude 'https://github.com/kumahq/kuma/pull' --exclude 'https://github.com/spiffe/spiffe/blob/main/standards/X509-SVID.md.*' --rate-limit 50 --timeout 60
       - name: link checker dev docs
         run: |
-          `go env GOPATH`/bin/muffet ${URL}/docs/dev --buffer-size 8192 --exclude https://twitter.com --max-connections-per-host=8 --exclude 127.0.0.1 --exclude 'https://github.com/kumahq/kuma/pull' --exclude 'https://github.com/spiffe/spiffe/blob/main/standards/X509-SVID.md.*' --exclude https://download.konghq.com --rate-limit 50 --timeout 60
+          $(go env GOPATH)/bin/muffet ${URL}/docs/dev --buffer-size 8192 --exclude https://twitter.com --max-connections-per-host=8 --exclude 127.0.0.1 --exclude 'https://github.com/kumahq/kuma/pull' --exclude 'https://github.com/spiffe/spiffe/blob/main/standards/X509-SVID.md.*' --exclude https://download.konghq.com --rate-limit 50 --timeout 60
 
   installer-sh:
     name: Test installer.sh

diff --git a/app/_src/policies/meshgatewayinstance.md b/app/_src/policies/meshgatewayinstance.md
@@ -120,6 +120,6 @@ spec:
 
 {% endif_version %}
 
-## schema
+## Schema
 
 {% json_schema kuma.io_meshgatewayinstances type=crd %}
diff --git a/jekyll-kuma-plugins/lib/jekyll/kuma-plugins/liquid/tags/jsonschema.rb b/jekyll-kuma-plugins/lib/jekyll/kuma-plugins/liquid/tags/jsonschema.rb
@@ -23,11 +23,11 @@ def render(context)
             data = @type.load("#{base_path}/#{release}")
 
             <<~TIP
-              <div id='markdown_html'></div>
+              <div id="markdown_html"></div>
 
               <script type="text/javascript">
               const data = #{JSON.dump(data)};
-              document.addEventListener("DOMContentLoaded", function(){
+              document.addEventListener("DOMContentLoaded", function() {
                 // create an instance of JSONSchemaMarkdown
                 const Doccer = new JSONSchemaMarkdown();
 
@@ -40,7 +40,7 @@ def render(context)
                 const converter = new showdown.Converter();
 
                 // use the converter to make html from the markdown
-                document.getElementById('markdown_html').innerHTML = converter.makeHtml(Doccer.markdown);
+                document.getElementById("markdown_html").innerHTML = converter.makeHtml(Doccer.markdown);
               });
               </script>
             TIP