Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(MeshService): add migration notes #1899

Merged
merged 2 commits into from
Sep 23, 2024
Merged

docs(MeshService): add migration notes #1899

merged 2 commits into from
Sep 23, 2024

Conversation

michaelbeaumont
Copy link
Contributor

No description provided.

@netlify Netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for kuma ready!

Name Link
🔨 Latest commit 467d33b
🔍 Latest deploy log https://app.netlify.com/sites/kuma/deploys/66f16ad17df9d40008e508bc
😎 Deploy Preview https://deploy-preview-1899--kuma.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 91 (🔴 down 1 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 85 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@michaelbeaumont
docs(MeshService): add migration notes
4d72644 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont marked this pull request as ready for review September 19, 2024 09:48
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner September 19, 2024 09:48
@michaelbeaumont michaelbeaumont requested review from slonka and Automaat and removed request for a team September 19, 2024 09:48
@michaelbeaumont michaelbeaumont linked an issue Sep 19, 2024 that may be closed by this pull request
MeshService migration #1900
Closed
slonka
slonka approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general 👍

app/_src/networking/meshservice.md Show resolved Hide resolved
app/_src/networking/meshservice.md Outdated Show resolved Hide resolved
@michaelbeaumont
docs: add more explicit migration
467d33b 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont merged commit 3574ebf into kumahq:master Sep 23, 2024
16 checks passed
@michaelbeaumont michaelbeaumont deleted the docs/ms-migration branch September 23, 2024 13:49
@kong-docs kong-docs mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Automaat Automaat Awaiting requested review from Automaat Automaat is a code owner automatically assigned from kumahq/kuma-website-maintainers

@slonka slonka Awaiting requested review from slonka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MeshService migration
2 participants
@michaelbeaumont @slonka