Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll tabs to top on click #1955

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

fabianrbz
Copy link
Contributor

Pages where "jumping" when clicking on tabs because the difference in height (and that we toggle all the tabs with the same slug).

As proposed in slack scroll tabs to top on click

Did you sign your commit? Instructions

Have you read Contributing guidelines?

Signed-off-by: Fabian Rodriguez <fabian.rodriguez@konghq.com>
@fabianrbz fabianrbz requested a review from a team as a code owner October 10, 2024 14:35
@fabianrbz fabianrbz requested review from michaelbeaumont and slonka and removed request for a team October 10, 2024 14:35
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for kuma ready!

Name Link
🔨 Latest commit 0faa42d
🔍 Latest deploy log https://app.netlify.com/sites/kuma/deploys/6707e62c0bda42000803331e
😎 Deploy Preview https://deploy-preview-1955--kuma.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 57 (🔴 down 38 from production)
Accessibility: 90 (no change from production)
Best Practices: 100 (no change from production)
SEO: 85 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@lahabana lahabana enabled auto-merge (squash) October 10, 2024 15:26
@lahabana lahabana merged commit 67ec727 into kumahq:master Oct 10, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants