Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(meshtls): design of MeshTLS #11202

Merged
merged 1 commit into from
Aug 26, 2024
Merged

docs(meshtls): design of MeshTLS #11202

merged 1 commit into from
Aug 26, 2024

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Aug 23, 2024

Checklist prior to review

https://docs.google.com/document/d/1zA1q1hD3PN7c1EsnxkwggtBR08-8i5voZG3yNJyjQfI/edit#heading=h.n6cmlf1eel2z

  • Link to relevant issue as well as docs and UI issues -- closes Design MeshTLS policy #4622
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Aug 23, 2024
@slonka slonka requested a review from a team as a code owner August 23, 2024 12:05
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had one comment about making sure the schema is clear for the chosen option compared to other example resources.

@slonka
Copy link
Contributor Author

slonka commented Aug 26, 2024

@lobkovilya please approve here or as you did in the doc

@slonka slonka merged commit 150bbd4 into kumahq:master Aug 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design MeshTLS policy
3 participants