Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kuma-cp): use ResourceIdentifier in MeshContext structs #11203

Merged
merged 29 commits into from
Aug 29, 2024
Merged

feat(kuma-cp): use ResourceIdentifier in MeshContext structs #11203

merged 29 commits into from
Aug 29, 2024

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Aug 23, 2024 •
edited
Loading

  • use ResourceIdentifier in mesh context and proxy objects
  • change in the public API for MeshMultiZoneService status. Storing only name of the MeshService is not enough to uniquely identify the resource
  • resolve BackendRefs in MeshTCPRoute and MeshHTTPRoute

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lobkovilya
chore(kuma-cp): create list of outbounds to use in plugins instead of…
5e9c24c 
… the 'dpp.GetOutbounds()'

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
chore(kuma-cp): make check
8c7c6fa 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
Merge branch 'master' into refactor/move-outbounds-from-dpp
af91e4b
@lobkovilya
fix unit tests
2528198 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
make check
bccaf84 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
Merge branch 'master' into refactor/move-outbounds-from-dpp
632fda9 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>

# Conflicts:
#	pkg/plugins/policies/meshhttproute/plugin/v1alpha1/plugin_test.go
#	pkg/plugins/policies/meshtcproute/plugin/v1alpha1/plugin_test.go
#	pkg/plugins/policies/meshtimeout/plugin/v1alpha1/plugin.go
@lobkovilya
feat(kuma-cp): add backendRef indexes to the rules
52df36d 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
feat(kuma-cp): golden files
538dd71 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
feat(kuma-cp): unit tests
ea41825 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
Merge branch 'master' into feat/add-backendref-indexes
33e7b97 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>

# Conflicts:
#	pkg/plugins/policies/core/rules/rules.go
@lobkovilya
add field comments
4e5fab1 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
feat(kuma-cp): use ResourceIdentifier in MeshContext structs
6b599c0 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
feat(kuma-cp): make check
66174d2 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
feat(kuma-cp): make check
e9f3284 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
feat(kuma-cp): update golden files
88bec8c 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
feat(kuma-cp): tests
c973e40 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
feat(kuma-cp): remove backendKey
15ee662 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
Merge branch 'master' into refactor/replace-legacy-outbounds-with-new
624bcb1 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>

# Conflicts:
#	pkg/plugins/policies/core/rules/resourcerules.go
#	pkg/plugins/policies/core/rules/rules.go
#	pkg/plugins/policies/core/xds/meshroute/clusters.go
#	pkg/plugins/policies/meshhttproute/plugin/v1alpha1/plugin_test.go
#	pkg/plugins/policies/meshtcproute/plugin/v1alpha1/listeners.go
#	pkg/plugins/policies/meshtcproute/plugin/v1alpha1/listeners_backendrefs.go
@lobkovilya
fix unit test after merging
d166b5e 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya marked this pull request as ready for review August 27, 2024 15:47
@lobkovilya lobkovilya requested a review from a team as a code owner August 27, 2024 15:47
@lobkovilya lobkovilya requested review from jijiechen, lukidzi, Automaat and jakubdyszkiewicz and removed request for a team August 27, 2024 15:47
@lobkovilya
fix e2e test
ae09454 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
lukidzi
lukidzi reviewed Aug 28, 2024
View reviewed changes
pkg/xds/context/context.go Outdated Show resolved Hide resolved
lukidzi
lukidzi reviewed Aug 28, 2024
View reviewed changes
pkg/xds/context/context.go Outdated Show resolved Hide resolved
@lobkovilya
remove debug prints
e262c46 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
jakubdyszkiewicz
jakubdyszkiewicz approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having a bit of a hard time to wrap my head around those changes. Aside of some nits it looks ok

@lobkovilya
Merge branch 'master' into refactor/replace-legacy-outbounds-with-new
af3282b 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>

# Conflicts:
#	pkg/plugins/policies/meshtcproute/plugin/v1alpha1/listeners_backendrefs.go
#	pkg/plugins/policies/meshtcproute/plugin/v1alpha1/plugin_test.go
@lobkovilya
fix unit
2c748bb 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
code review
0c76dba 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
code review
ee68ecd 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
remove commented code
3c4bdb3 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
remove commented code
eceeb38 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
Merge branch 'master' into refactor/replace-legacy-outbounds-with-new
51ec594 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>

# Conflicts:
#	pkg/plugins/policies/core/xds/meshroute/listeners.go
@lobkovilya
Merge branch 'master' into refactor/replace-legacy-outbounds-with-new
1246c37 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>

# Conflicts:
#	pkg/plugins/policies/core/rules/resourcerules.go
@lobkovilya lobkovilya merged commit fc68afc into kumahq:master Aug 29, 2024
15 checks passed
@lobkovilya lobkovilya deleted the refactor/replace-legacy-outbounds-with-new branch August 29, 2024 14:08
@lobkovilya lobkovilya mentioned this pull request Sep 9, 2024
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@lukidzi lukidzi lukidzi approved these changes

@jijiechen jijiechen Awaiting requested review from jijiechen jijiechen is a code owner automatically assigned from kumahq/kuma-maintainers

@Automaat Automaat Awaiting requested review from Automaat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lobkovilya @jakubdyszkiewicz @lukidzi