Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*) add reference documentation generator #2140

Merged
merged 6 commits into from
Jun 16, 2021
Merged

feat(*) add reference documentation generator #2140

merged 6 commits into from
Jun 16, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Jun 10, 2021

Summary

Add tooling to generate CLI reference documentation to the path named
in "$DESTDIR". The goal is for the website to generate reference docs
on each new version.

This updates kumahq/kuma-website#447.

Full changelog

  • Add makefile targets to generate reference documentation

Issues resolved

N/A

Documentation

N/A

Testing

Manual testing.

Add tooling to generate CLI reference documentation to the path named
in "$DESTDIR". The goal is for the website to generate reference docs
on each new version.

This updates kumahq/kuma-website#447.

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach requested a review from a team as a code owner June 10, 2021 01:39
@jpeach
Copy link
Contributor Author

jpeach commented Jun 10, 2021

cc @Bradamant3 @tharun208

@tharun208
Copy link
Contributor

tharun208 commented Jun 11, 2021

cc @Bradamant3 @tharun208

looks good. I will rebase this on #2101 once this is merged and update the man pages section.

Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: James Peach <james.peach@konghq.com>
Per discussion in kuma-website#447, generate the command documentation
locally (as a side-effect of `make check`).

Signed-off-by: James Peach <james.peach@konghq.com>
If we allow cobra to emit the timestamp on the generated docs, then
they change every time we run `make check`, which is undesirable.

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach merged commit ecf68d9 into kumahq:master Jun 16, 2021
@jpeach jpeach deleted the feat/generate-reference-docs branch June 16, 2021 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants