fix(kuma-cp) supported versions fix #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we were using caret ranges `^` instead of tilde ranges `~` to catch the latest versions (1.1.0, 1.2.0) both of them could catch the 1.2.0 version. Versions are delivered to our gui as a hashmap, and when gui on the 1.2.0 version was asking our api for the supported version of envoy it could receive the response from range `^1.2.0` and then, everything was fine, and sometimes it could receive a response from the `^1.1.0` range, and then it was displaying warning. It was happening because in the gui, we are iterating over the hashmap with versions, and there is no consistency in the order of keys (which is normal). Also added tests to make sure there is always only one constraint per version, to not allow similar situation to happen again. Signed-off-by: Bart Smykla <bartek@smykla.com>
jakubdyszkiewicz
approved these changes
Jun 22, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jun 22, 2021
As we were using caret ranges `^` instead of tilde ranges `~` to catch the latest versions (1.1.0, 1.2.0) both of them could catch the 1.2.0 version. Versions are delivered to our gui as a hashmap, and when gui on the 1.2.0 version was asking our api for the supported version of envoy it could receive the response from range `^1.2.0` and then, everything was fine, and sometimes it could receive a response from the `^1.1.0` range, and then it was displaying warning. It was happening because in the gui, we are iterating over the hashmap with versions, and there is no consistency in the order of keys (which is normal). Also added tests to make sure there is always only one constraint per version, to not allow similar situation to happen again. Signed-off-by: Bart Smykla <bartek@smykla.com> (cherry picked from commit e2bd183)
bartsmykla
pushed a commit
that referenced
this pull request
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As we were using caret ranges
^instead of tilde ranges~to catch the latest versions (1.1.0, 1.2.0) both of them could
catch the 1.2.0 version. Versions are delivered to our gui
as a hashmap, and when gui on the 1.2.0 version was asking our api
for the supported version of envoy it could receive the response
from range
^1.2.0and then, everything was fine, and sometimesit could receive a response from the
^1.1.0range, and thenit was displaying warning.
It was happening because in the gui, we are iterating over
the hashmap with versions, and there is no consistency in
the order of keys (which is normal).
Also added tests to make sure there is always only one constraint
per version, to not allow similar situation to happen again.
Testing