Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON pretty printer modifies message content #1

Closed
winne42 opened this issue Sep 9, 2022 · 1 comment · Fixed by #2
Closed

JSON pretty printer modifies message content #1

winne42 opened this issue Sep 9, 2022 · 1 comment · Fixed by #2

Comments

@winne42
Copy link

winne42 commented Sep 9, 2022 •
edited
Loading

We observed that "Format JSON" modifies the content of messages read from Kafka by escaping certain characters:

image

We tracked this down as being the default behavior of Gson, for added security if JSON is used in an HTML context. As the messages in kafkavisualizer are not (automatically) in an HTML context, this behavior is unexpected, and in our case unwanted. I will open a PR to disable HTML escaping for JSON pretty-printing.
winne42 pushed a commit to winne42/kafkavisualizer that referenced this issue Sep 9, 2022
@winfriedgerlach
kumait#1 disable HTML escaping in JSON pretty printer
665e365
@winne42 winne42 mentioned this issue Sep 9, 2022
Merged
@kumait
Copy link
Owner

kumait commented Sep 9, 2022

Thanks @winne42, I agree, I will merge your PR.

@kumait kumait closed this as completed Sep 9, 2022
kumait added a commit that referenced this issue Sep 9, 2022
@kumait
Merge pull request #2 from winne42/feature/#1_disable_HTML_escaping_i…
45c0f52 
…n_JSON_pretty_printer

#1 disable HTML escaping in JSON pretty printer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1 disable HTML escaping in JSON pretty printer winne42/kafkavisualizer
2 participants
@kumait @winne42