Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Github Actions #10

Merged
merged 3 commits into from
Oct 3, 2021
Merged

Add Github Actions #10

merged 3 commits into from
Oct 3, 2021

Conversation

DonRenando
Copy link
Contributor

#3 Add Github Actions to test and build go code

jmaitrehenry
jmaitrehenry reviewed Oct 3, 2021
View reviewed changes
Copy link
Member

@jmaitrehenry jmaitrehenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, it's really clean!
Can you just add the cover option and I will merge it?

.github/workflows/go.yaml Outdated
- name: Checkout code
uses: actions/checkout@v2
- name: Test
run: go test -v ./...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add --cover option?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes of course :)

jmaitrehenry
jmaitrehenry approved these changes Oct 3, 2021
View reviewed changes
Copy link
Member

@jmaitrehenry jmaitrehenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@jmaitrehenry jmaitrehenry merged commit a1e03d2 into kumojin:main Oct 3, 2021
@jmaitrehenry jmaitrehenry mentioned this pull request Oct 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaitrehenry jmaitrehenry jmaitrehenry approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DonRenando @jmaitrehenry