Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update dependencies #20

Merged
merged 2 commits into from
Nov 2, 2022
Merged

build: update dependencies #20

merged 2 commits into from
Nov 2, 2022

Conversation

xballoy
Copy link
Contributor

@xballoy xballoy commented Oct 28, 2022

Update Echo from 4.6.1 to 4.9.1

golang.org/x/text v0.4.0 // indirect
)

go 1.17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the minimal version of go is 1.16, it should be 1.16 here too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was inspired by what Echo does. They put go 1.17 (see labstack/echo#2049) to benefit new from new Go features but still test up to 1.16 (https://github.com/labstack/echo/blob/master/.github/workflows/echo.yml#L31).

However I'm still trying to figure out why the golangcli-lint fails (maybe this golangci/golangci-lint#2649 but still need to run some tests to be sure).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the end I used go 1.17 here and in the CI. I never managed to run the CI with go 1.16, golangcli-lint always fails with this version and the dependency bump.

go 1.17 is the same version than echo 4.9.1 so I think we're good here.

@xballoy xballoy requested a review from jmaitrehenry November 1, 2022 22:14
@jmaitrehenry jmaitrehenry merged commit 470f949 into kumojin:main Nov 2, 2022
@xballoy xballoy deleted the xba/update-deps branch November 2, 2022 15:01
@xballoy xballoy mentioned this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants