Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored tests, removed testify/assert #6

Merged
merged 2 commits into from
Oct 2, 2021
Merged

Refactored tests, removed testify/assert #6

merged 2 commits into from
Oct 2, 2021

Conversation

RomanSerikov
Copy link
Contributor

Hi!

I tried to resolve #2.

Hope you like it :)

LukaszKokot
LukaszKokot approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@LukaszKokot LukaszKokot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Looks good to me 🚀

@LukaszKokot LukaszKokot self-requested a review October 1, 2021 12:05
LukaszKokot
LukaszKokot reviewed Oct 1, 2021
View reviewed changes
Copy link
Member

@LukaszKokot LukaszKokot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, forgot just one thing! Could you please run go mod tidy ? Since we don't use the assert package, it can now be safely removed 🙂

@LukaszKokot LukaszKokot self-requested a review October 1, 2021 12:13
@RomanSerikov
Copy link
Contributor Author

You are right, forgot about it :)

jmaitrehenry
jmaitrehenry approved these changes Oct 2, 2021
View reviewed changes
Copy link
Member

@jmaitrehenry jmaitrehenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmaitrehenry jmaitrehenry merged commit e16cd37 into kumojin:main Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaitrehenry jmaitrehenry jmaitrehenry approved these changes

@LukaszKokot LukaszKokot Awaiting requested review from LukaszKokot

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve tests
3 participants
@RomanSerikov @jmaitrehenry @LukaszKokot