Create a temporary context for the first middleware to run for not sending content to client if the middleware fail #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaitrehenry
force-pushed
the
fix-mixed-middleware
branch
from
d0ec91b to
a88d318
Compare
LukaszKokot
reviewed
Oct 4, 2021
LukaszKokot
reviewed
Oct 4, 2021
LukaszKokot
reviewed
Oct 4, 2021
LukaszKokot
reviewed
Oct 4, 2021
LukaszKokot
reviewed
Oct 4, 2021
…nding content to client if the middleware fail
jmaitrehenry
force-pushed
the
fix-mixed-middleware
branch
from
a88d318 to
767f738
Compare
LukaszKokot
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, if the first middleware write something in the response, the content is really written (response code, content, header, etc).
The idea is to create a temporary Response for holding the data temporary.
Plus, if the second middleware fail, we send the content of the first one.