New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dictionary lookup to use gem path by default #29

Merged

kupolak merged 1 commit into kupolak:master from Studiosity:master

Feb 7, 2020

Contributor

abrom commented Dec 10, 2019

When the gem is loaded in another ruby app, the current code requires that the app also have it's own version of the dictionary.

Proposed change adds accessor methods for the dictionary path, defaulting to the textstat gem path.

Fixes loading of the dictionary when the cwd isn't the gem path
Allows custom dictionary paths to be specified (if wanting to overload the textstat dictionaries?)

Note that this does change the default behaviour for anyone using the textstat gem (in another app) and they ARE overloading the dictionary.


          Update dictionary lookup to use gem path by default

5f934ef

Contributor Author

abrom commented Dec 10, 2019

This would also appear to resolve #28

kupolak merged commit 8ec8b3c into kupolak:master

kupolak mentioned this pull request

Gem can't find the dictionaries #28

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet