Fixing event leak when using multiple event handlers on the same element

kupriyanenko · Oct 8, 2015 · 8491f31 · 8491f31
1 parent cab3e77
commit 8491f31
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/dist/jbone.js b/dist/jbone.js
@@ -1,5 +1,5 @@
 /*!
- * jBone v1.1.1 - 2015-08-13 - Library for DOM manipulation
+ * jBone v1.1.1 - 2015-10-08 - Library for DOM manipulation
  *
  * http://jbone.js.org
  *
@@ -350,7 +350,10 @@ jBone.event = {
             eventType = event.split(".")[0];
             events[eventType] = events[eventType] || [];
 
-            if (!events[eventType].length) {
+            if (events[eventType].length) {
+                // override with previous event handler
+                eventHandler = events[eventType][0].fn;
+            } else {
                 el.addEventListener && el.addEventListener(eventType, eventHandler, false);
             }
 

diff --git a/dist/jbone.min.js b/dist/jbone.min.js
diff --git a/src/event.js b/src/event.js
@@ -85,7 +85,10 @@ jBone.event = {
             eventType = event.split(".")[0];
             events[eventType] = events[eventType] || [];
 
-            if (!events[eventType].length) {
+            if (events[eventType].length) {
+                // override with previous event handler
+                eventHandler = events[eventType][0].fn;
+            } else {
                 el.addEventListener && el.addEventListener(eventType, eventHandler, false);
             }