Fixing event leak when using multiple event handlers on the same element #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kupriyanenko
added a commit
that referenced
this pull request
Oct 9, 2015
Fixing event leak when using multiple event handlers on the same element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
When using multiple jBone event handlers on the same element, removing the first added handler before any other will result in leaking the native event handler as to it cannot be removed anymore.
Consider the following example:
Here we are removing the first jBone handler and after that - the second one. The first jBone handler was the one that was put into addEventListener's callback argument, but it will not call removeEventListener as to there is still another event in the events array. Removing the second handler does call removeEventListener, but it does not remove the native handler because the callback argument does not match with the one that was put into addEventListener.