rename FleetCluster to KubeConfigSecretRef

[Xieql]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

current FleetCluster struct is just for render

and we have already defined fleetCluster here

kurator/pkg/fleet-manager/fleet_cluster.go

Lines 34 to 38 in 2871c99

	type fleetCluster struct {
	Secret string
	SecretKey string
	client *kclient.Client
	}

and we are going to make it public for #481

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[netlify]

✅ Deploy Preview for kurator-dev canceled.

Name	Link
🔨 Latest commit	5de1517
🔍 Latest deploy log	https://app.netlify.com/sites/kurator-dev/deploys/6565d2e90c8546000815a345

[hzxuzhonghu]

can we use the FleetCluster, if any field miss, we can add it

[Xieql]

the origin FleetCluster 's fileld value is comes from two struct fleetCluster and ClusterKey ,
so maybe we can not directly add fileld in FleetCluster, or we need merge those two struct into one struct, which may affect many other code

kurator/pkg/fleet-manager/fleet_cluster.go

Lines 34 to 43 in 2871c99

	type fleetCluster struct {
	Secret string
	SecretKey string
	client *kclient.Client
	}
	type ClusterKey struct {
	Kind string
	Name string
	}

this is the most used usage:

kurator/pkg/fleet-manager/fleet_plugin_distributedstorage.go

Lines 78 to 81 in 83fdec0

	b, err := plugin.RenderClusterStorage(f.Manifests, fleetNN, fleetOwnerRef, plugin.RenderableFleetCluster{
	Name: key.Name,
	SecretName: cluster.Secret,
	SecretKey: cluster.SecretKey,

FleetCluster.Name:       ClusterKey.Name, 
FleetCluster.SecretName: fleetCluster.Secret, 
FleetCluster.SecretKey:  fleetCluster.SecretKey, 

[hzxuzhonghu]

Looked into the code closely, and the FleetCluster represents the kubeconfig secret ref.

We only need the secret name and key which kubeconfg is stored. Even the cluster name is not needed.

So we can rename it to KubeConfigSecretRef or SecretRef or something

[Xieql]

Looked into the code closely, and the FleetCluster represents the kubeconfig secret ref.

We only need the secret name and key which kubeconfg is stored. Even the cluster name is not needed.

So we can rename it to KubeConfigSecretRef or SecretRef or something

ok

[Xieql]

/label tide/merge-method-squash

[hzxuzhonghu]

nit: The Name can be removed

[Xieql]

Currently, it is used solely for rendering and requires the name parameter.

If we remove name, we will need to refactor many corresponding functions

However, I think that refactoring them would not be wise.

such as

kurator/pkg/fleet-manager/plugin/render.go

Lines 30 to 46 in 5de1517

	type FleetPluginConfig struct {
	Name string
	Component string
	Fleet types.NamespacedName
	OwnerReference *metav1.OwnerReference
	Cluster *KubeConfigSecretRef
	Chart ChartConfig
	Values map[string]interface{}
	}
	func (plugin FleetPluginConfig) ResourceName() string {
	if plugin.Cluster != nil {
	return plugin.Component + "-" + plugin.Cluster.Name
	}
	return plugin.Component
	}

[hzxuzhonghu]

I did see that, it is unused

[Xieql]

you are right, it is unused

[kurator-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hzxuzhonghu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Xieql]

If the name field is removed, the test fails with the message 'template: fleet plugin template:4:13: executing "fleet plugin template" at <$.ResourceName>: can't evaluate field ResourceName in type plugin.FleetPluginConfig'.

Therefore, it might be best to retain the field, as there seems to be no effective method to address this issue

[hzxuzhonghu]

/lgtm