Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window size customization #180

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Window size customization #180

wants to merge 1 commit into from

Conversation

r4ulill0
Copy link

@r4ulill0 r4ulill0 commented Sep 16, 2022

Resolves #60
I have changed the fixed size to a custom one.
The base height and width is still there because it was the easier way to modify the bezier calculation.

Window size is established on config.json and this gives some space so a bigger background can be rendered in all game modes.
The user has to fine-tune other configuration parameters for this to work as intended, pawsStart and ending points have to be adjusted with the new height. Other artifacts that don't use the bezier calculation will be pushed down and should keep their standard dimensions to be adequately rendered.

Note: The wobbly line between the keyboard and mousepad is a result of my image editing skills, not related to code, the skin is like that 😆 .
image

In this example I used an increased height of 260 (612 pixels x 612 pixels window) so I had to modify the pawPoints in the config.json like this:
"pawStartingPoint": [211, 419], "pawEndingPoint": [258, 488]

Mode 2 example with increased width too:
image

@EbyAsh
Copy link

EbyAsh commented Oct 12, 2022

Hello! first of all thank you for making this window size customization but i encounter some error with "pawStartingPoint":
may i ask your config.json files?

@EbyAsh
Copy link

EbyAsh commented Oct 12, 2022

image
something like thhis

@r4ulill0
Copy link
Author

r4ulill0 commented Oct 12, 2022

{
    "mode": 5,
    "resolution": {
        "letterboxing": false,
        "width": 1920,
        "height": 1080,
        "horizontalPosition": 0,
        "verticalPosition": 0
    },
    "decoration": {
        "window_width": 800,
        "window_height": 612,
        "leftHanded": false,
        "rgb": [255, 255, 255],
        "offsetX": [0, 11],
        "offsetY": [0, -65],
        "scalar": [1.0, 1.0]
    },
    "osu": {
        "mouse": true,
        "toggleSmoke": false,
        "paw": [255, 255, 255],
        "pawEdge": [0, 0, 0],
        "key1": [90],
        "key2": [88],
        "smoke": [67],
        "wave": []
    },
    "taiko": {
        "leftCentre": [88],
        "rightCentre": [67],
        "leftRim": [90],
        "rightRim": [86]
    },
    "catch": {
        "left": [37],
        "right": [39],
        "dash": [16]
    },
    "mania": {
        "4K": true,
        "key4K": [68, 70, 74, 75],
        "key7K": [83, 68, 70, 32, 74, 75, 76]
    },
    "custom": {
        "background": "img/osu/mousebg.png",
        "mouse": true,
        "mouseImage": "img/osu/mouse.png",
        "mouseOnTop": true,
        "offsetX": 0,
        "offsetY": 260,
        "scalar": 1.0,
        "paw": [255, 255, 255],
        "pawEdge": [0, 0, 0],
        "keyContainers": []
    },
    "mousePaw": {
        "mousePawComment": "coordinates start in the top left of the window",
        "pawStartingPoint": [211, 419],
        "pawEndingPoint": [258, 488]
    }
}

It`s not the same i used on the pictures above. Hope it works.

@EbyAsh
Copy link

EbyAsh commented Oct 15, 2022

image
thank you for adding window size customization, by any chance can you help me to make the hotkey go to up more? how many i edit it, it ends up at that place so far. i know this is too much, can you help me?

@r4ulill0
Copy link
Author

I think you have to play with offsetY but I am not that confident, it's been a while since I developed this. I can't help you further sorry.

@EbyAsh
Copy link

EbyAsh commented Oct 18, 2022

image
by any chance can i edit mouse range trough config?

@demonspxwn
Copy link

hey! I used your code but it didnt seem to change the size of my bongo cat, idk what I did wrong ^^' (my background pic is 612x480)
image

@r4ulill0
Copy link
Author

r4ulill0 commented May 6, 2023

First of all check if you have used my release as kuroni version doesn't have this feature.

Also it could be that you swapped width and height.

I recommend you to make a copy of the initial configuration and work slowly from there. Start increasing either width or height by a lot (1000 for example) and fine tune those values until you see the background on its place. After that, it could be that the arm of the bongo cat appears disjointed. If that happens, you will have to adjust pawStartingPoint and pawEndingPoint until the paw is in its place again.

The size is increased from the top to the bottom so if you increase the height the cat will be further down but the image starts at the top so it could be hanging in the air if the sizes are not exact. Background size and window size have to be the same.

It's been a while since I developed this and I think it's never going to be merged so I'm going to unsubscribe from this PR. Good luck.

Repository owner deleted a comment from chasedson Feb 7, 2024
@Therepup
Copy link

Therepup commented Jul 1, 2024

I try to use your release version but
image
it has this error when open and installing the font does nothing to fix it

@ZackeryRSmith
Copy link

@Therepup, this doesn't appear to be an issue with this PR. Please ensure the exe is extracted and inside the same folder, which contains a font folder. If this is still an issue you would like to fix...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Window size configuration
5 participants