feat!: refactoring collision info (again) and adding character animations #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzanardo
approved these changes
Dec 4, 2023
README.md
Outdated
| ##### Character animations | ||
|
|
||
| Characters are typically rendered visually as a `SpriteAnimation`, however most | ||
| likely thre is a different animation for different states of the character. |
There was a problem hiding this comment.
Suggested change
| likely thre is a different animation for different states of the character. | |
| likely there is a different animation for different states of the character. |
README.md
Outdated
| likely thre is a different animation for different states of the character. | ||
| That's where `CharacterAnimation` comes in. | ||
|
|
||
| A `CharacterAnimation` is specialized `SpriteAnimationGroupComponent`, so you |
There was a problem hiding this comment.
Suggested change
| A `CharacterAnimation` is specialized `SpriteAnimationGroupComponent`, so you | |
| A `CharacterAnimation` is a specialized `SpriteAnimationGroupComponent`, so you |
README.md
Outdated
| That's where `CharacterAnimation` comes in. | ||
|
|
||
| A `CharacterAnimation` is specialized `SpriteAnimationGroupComponent`, so you | ||
| can set all the animations as map on the component and the update the current |
There was a problem hiding this comment.
Suggested change
| can set all the animations as map on the component and the update the current | |
| can set all the animations as map on the component and update the current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring
CollisionInfoto allow client code to differentiate non-solid collisions from solid and to track multiple solid collisions in each direction. This means if a player is standing between two ground tiles (on level ground) both tiles should be incollisionInfo.downCollisions. The sorting order of the collisions is always the same, anddownCollisionwill continue to return the same collision it always has (the first one).Also adding
debugCollisionstoPhysicalEntityAlso adding a
CharacterAnimationcomponent which extendsSpriteGroupAnimationComponentand automatically handles positioning the animation properly around the parent's hitbox.Also adding more status mixins to control collision detection and world interactions.