fix: Clarify the manager CLI command deploy kontrol service location argument #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostbean
approved these changes
Sep 25, 2024
lostbean
added a commit
that referenced
this pull request
Sep 26, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.0](0.2.7...0.3.0) (2024-09-26) ### ⚠ BREAKING CHANGES * new gateway management ([#238](#238)) ### Features * E2E tests iteration [#2](#2) ([#237](#237)) ([c4f6b67](c4f6b67)) * new gateway management ([#238](#238)) ([b5a9916](b5a9916)) ### Bug Fixes * add missing resources to policy ([#249](#249)) ([0ade319](0ade319)) * Clarify the manager CLI command deploy kontrol service location argument ([#247](#247)) ([54bdc21](54bdc21)) * Do not alter the istio-system namespace ([#246](#246)) ([1c98304](1c98304)) * Exit with code 1 upon errors in the CLI ([#243](#243)) ([63c640e](63c640e)) * Handle gateway case where the baseline is missing or not labelled ([#245](#245)) ([b0b6bb2](b0b6bb2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users are confused about the kardinal kontrol service location argument. Some of them are not able to differentiate between the kardinal manager location and the kontrol service location. I myself was also confused when I saw the manager deploy command.