fix: fix broken website CSS by refactoring styled-components SSR logic #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying kardinal with
|
| Latest commit: |
24bf7fc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://76b3500f.kardinal.pages.dev |
| Branch Preview URL: | https://sbrown-fix-broken-css.kardinal.pages.dev |
galenmarchetti
approved these changes
Sep 27, 2024
leoporoli
pushed a commit
that referenced
this pull request
Sep 30, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.2](0.3.1...0.3.2) (2024-09-28) ### Bug Fixes * add the --service flag in the kardinal flow telepresence intercept command ([#259](#259)) ([5d22282](5d22282)) * fix broken website CSS by refactoring styled-components SSR logic ([#257](#257)) ([505e885](505e885)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of mistakes in the code resulted in the page not being properly server-side rendered in the Next.JS static export. This means all DOM hydration and stylesheet injection was being performed client-side, which defeats the purpose of a static export / SSR with NextJS. This also seemed to be non-deterministic in terms of the order stylesheets were injected into the
<head>client-side, which resulted in buggy / unstyled rendering for some users.The following changes seems to have fixed the issue by restoring expected SSR functionality:
createGlobalStylefunctionality fromstyled-componentslayout.tsxis server side rendered by moving all context providers to a separate client component.Suspenseboundary that was required for using the NextJSuseSearchParamshook. Using native browser APIs (window.location.search) works fine here, so no need for a suspense boundary with this custom hook.