feat: increase max upload size #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnabasbusa
approved these changes
Sep 17, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
🤖 I have created a release *beep* *boop* --- ## [1.3.0](1.2.0...1.3.0) (2024-09-18) ### Features * increase max upload size ([#2552](#2552)) ([b6a0d91](b6a0d91)) ### Bug Fixes * Fix typo in the port name format help ([#2550](#2550)) ([256d71a](256d71a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users trying to use
ImageBuildSpecto build images inside their packages have repositories greater than 100MB. Image building in Kurtosis requires that the entire build context is within the package, and thus gets uploaded into the APIContainer where the validation step that builds images is done.This PR increases the upload limit of the compression / upload library to account for larger repositorie (2GB)
Is this change user facing?
YES
References (if applicable)
ethpandaops/optimism-package#72