Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.13に対応しました #155

Merged
merged 7 commits into from
Dec 24, 2024
Merged

Python 3.13に対応しました #155

merged 7 commits into from
Dec 24, 2024

Conversation

yuji38kwmt
Copy link
Collaborator

@yuji38kwmt yuji38kwmt commented Dec 12, 2024

#156 がマージされてから対応する

  • wheelファイルをビルドするpoetryのバージョンを最新にして、ビルドするときに生成されるclassifiersにPython 3.13が含まれるようにしました。
  • numpy 2.Xに対応させました。
  • Python 3.13でpoetry installが成功するように、開発版の依存関係を修正しました。

@yuji38kwmt yuji38kwmt changed the title Python 3.13対応 Python 3.13に対応しました Dec 15, 2024
@@ -23,24 +23,49 @@ annofabapi = "^1"
dataclasses-json = ">=0.5.7,<1"
fire = ">=0.3.1,<1"
more-itertools = "^8.5.0"
numpy = "^1.23.0"

numpy = ">=1.23, <3"
Copy link
Collaborator Author

@yuji38kwmt yuji38kwmt Dec 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.13ではnumpy 2.1以上でないとwheelファイルがPyPIにないため、numpy 2.X系も利用可能にしました。
https://app.travis-ci.com/github/kurusugawa-computer/annofab-3dpc-editor-cli/jobs/629047800

Comment on lines +60 to +67
numpy = [
{version="^2.1", python=">=3.13"}
]
# scipy 1.14.1以上でないと、Python 3.13用のwheelファイルがPyPIにないため、scipyのバージョンを指定する
scipy = [
{version="^1.14.1", python=">=3.13"}
]

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この指定がないと、Python 3.13でのpoetry installで失敗するため追加しました。
https://app.travis-ci.com/github/kurusugawa-computer/annofab-3dpc-editor-cli/jobs/629047800

pyproject.toml Outdated
Comment on lines 31 to 48

[tool.poetry.group.linter.dependencies]
ruff = "^0.8"
pytest = "^7.1.2"
mypy = "^1.11"
flake8 = "^7.1"
pylint = "^3.2"


[tool.poetry.group.formatter.dependencies]
black = "^22.6.0"
isort = "^5.10.1"
pylint = "^3.2"
# document


[tool.poetry.group.test.dependencies]
pytest = "^7.1.2"


[tool.poetry.group.documentation.dependencies]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[tool.poetry.group.dev-only.dependencies]のついで、他の開発用パッケージをグループ化しました。

@yuji38kwmt yuji38kwmt marked this pull request as ready for review December 15, 2024 07:03
@yuji38kwmt yuji38kwmt requested a review from seraphr December 15, 2024 07:03
Copy link
Contributor

@seraphr seraphr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python 3.13環境下でpoetry installして、make_sceneが動くことは確認したぞ

@seraphr seraphr merged commit 0b565fc into master Dec 24, 2024
2 checks passed
@seraphr seraphr deleted the python313-support branch December 24, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants