Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies for v1 branch #277

Merged
merged 8 commits into from
Feb 16, 2024
Merged

Conversation

satk0
Copy link
Collaborator

@satk0 satk0 commented Feb 15, 2024

No description provided.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d107aa) 100.00% compared to head (acf5352) 93.60%.

Additional details and impacted files
@@             Coverage Diff             @@
##                v1     #277      +/-   ##
===========================================
- Coverage   100.00%   93.60%   -6.40%     
===========================================
  Files           14       15       +1     
  Lines          600      641      +41     
===========================================
  Hits           600      600              
- Misses           0       41      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -21,12 +21,12 @@ jobs:
runs-on: ubuntu-20.04
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v4.1.1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't pin the version

@kuskoman
Copy link
Owner

@satk0 prometheus tests are failing

@kuskoman
Copy link
Owner

also, go mod tidy was not run

@kuskoman
Copy link
Owner

@satk0 seems like the upgrade-dependencies script differs between v1 and v2
also, you may want to check this pr #280

@satk0
Copy link
Collaborator Author

satk0 commented Feb 16, 2024

@kuskoman Thanks a ton for all the hints. I am giving it another try 😎

@kuskoman kuskoman merged commit 198ad36 into kuskoman:v1 Feb 16, 2024
17 checks passed
@satk0 satk0 deleted the v1-update-dependencies branch February 16, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants