Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list_contains implicit casting #4044

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Fix list_contains implicit casting #4044

merged 1 commit into from
Aug 7, 2024

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Aug 7, 2024

Description

Fixes #4042

Contributor agreement

test/test_files/function/list.test Show resolved Hide resolved
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.16%. Comparing base (7139a6a) to head (4971944).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4044   +/-   ##
=======================================
  Coverage   85.16%   85.16%           
=======================================
  Files        1297     1297           
  Lines       50536    50538    +2     
  Branches     6956     6958    +2     
=======================================
+ Hits        43037    43041    +4     
+ Misses       7368     7367    -1     
+ Partials      131      130    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 7, 2024

Benchmark Result

Master commit hash: 670db898a2ccb81823d1e444b349eec13183ceb3
Branch commit hash: cc84b03a5c7c3e13ef2b7846023725f9babf167f

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 699.65 685.54 14.11 (2.06%)
aggregation q28 11066.01 11391.03 -325.02 (-2.85%)
filter q14 160.25 160.94 -0.69 (-0.43%)
filter q15 159.64 162.29 -2.65 (-1.63%)
filter q16 339.38 334.05 5.33 (1.60%)
filter q17 481.41 480.75 0.66 (0.14%)
filter q18 1952.13 1954.48 -2.34 (-0.12%)
fixed_size_expr_evaluator q07 587.08 571.37 15.70 (2.75%)
fixed_size_expr_evaluator q08 793.84 788.84 4.99 (0.63%)
fixed_size_expr_evaluator q09 798.21 781.47 16.74 (2.14%)
fixed_size_expr_evaluator q10 274.03 272.70 1.32 (0.48%)
fixed_size_expr_evaluator q11 269.49 268.04 1.45 (0.54%)
fixed_size_expr_evaluator q12 271.03 267.62 3.41 (1.27%)
fixed_size_expr_evaluator q13 1503.14 1507.57 -4.43 (-0.29%)
fixed_size_seq_scan q23 162.33 156.53 5.80 (3.71%)
join q31 49.08 46.95 2.13 (4.54%)
ldbc_snb_ic q35 3613.84 3609.70 4.14 (0.11%)
ldbc_snb_ic q36 137.34 125.28 12.05 (9.62%)
ldbc_snb_is q32 10.70 10.74 -0.05 (-0.43%)
ldbc_snb_is q33 88.05 96.46 -8.40 (-8.71%)
ldbc_snb_is q34 97.58 96.66 0.92 (0.95%)
multi-rel multi-rel-large-scan 2884.46 2905.26 -20.80 (-0.72%)
multi-rel multi-rel-lookup 78.10 78.49 -0.39 (-0.49%)
multi-rel multi-rel-small-scan 83.80 69.52 14.28 (20.54%)
order_by q25 165.65 164.76 0.89 (0.54%)
order_by q26 485.03 495.45 -10.42 (-2.10%)
order_by q27 1433.70 1432.58 1.12 (0.08%)
scan_after_filter q01 206.51 205.47 1.03 (0.50%)
scan_after_filter q02 194.21 197.34 -3.13 (-1.59%)
shortest_path_ldbc100 q39 84.10 82.75 1.36 (1.64%)
var_size_expr_evaluator q03 2084.11 2094.28 -10.18 (-0.49%)
var_size_expr_evaluator q04 2285.61 2305.32 -19.71 (-0.85%)
var_size_expr_evaluator q05 2575.89 2572.47 3.42 (0.13%)
var_size_expr_evaluator q06 1361.49 1363.64 -2.15 (-0.16%)
var_size_seq_scan q19 1489.37 1492.22 -2.86 (-0.19%)
var_size_seq_scan q20 3180.57 3203.26 -22.68 (-0.71%)
var_size_seq_scan q21 2459.55 2546.02 -86.47 (-3.40%)
var_size_seq_scan q22 135.97 141.06 -5.09 (-3.61%)

@andyfengHKU andyfengHKU merged commit 8781c0b into master Aug 7, 2024
24 checks passed
@andyfengHKU andyfengHKU deleted the issue-4042 branch August 7, 2024 20:13
ray6080 pushed a commit that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: IN clause does not find a node
2 participants