Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list contains casting on empty list #4049

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Aug 8, 2024

Description

Fix a regression when we call list_contains on empty list.

Contributor agreement

Copy link

github-actions bot commented Aug 8, 2024

Benchmark Result

Master commit hash: 13b20efa4569b5d7e3c864c3f4988a063634c08a
Branch commit hash: 9a0ca679052ff293fb96407a85ede5fa473ddc4e

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 684.07 684.02 0.05 (0.01%)
aggregation q28 11623.45 11807.39 -183.94 (-1.56%)
filter q14 158.91 160.57 -1.67 (-1.04%)
filter q15 160.52 159.74 0.78 (0.49%)
filter q16 334.50 338.04 -3.55 (-1.05%)
filter q17 479.48 479.00 0.48 (0.10%)
filter q18 1941.41 1917.43 23.99 (1.25%)
fixed_size_expr_evaluator q07 570.81 570.34 0.47 (0.08%)
fixed_size_expr_evaluator q08 785.71 778.83 6.88 (0.88%)
fixed_size_expr_evaluator q09 780.88 779.97 0.92 (0.12%)
fixed_size_expr_evaluator q10 272.68 272.22 0.47 (0.17%)
fixed_size_expr_evaluator q11 268.17 267.46 0.72 (0.27%)
fixed_size_expr_evaluator q12 266.14 265.92 0.22 (0.08%)
fixed_size_expr_evaluator q13 1504.28 1496.30 7.98 (0.53%)
fixed_size_seq_scan q23 152.07 152.09 -0.02 (-0.01%)
join q31 49.38 44.46 4.92 (11.06%)
ldbc_snb_ic q35 3616.93 3624.70 -7.77 (-0.21%)
ldbc_snb_ic q36 130.37 127.96 2.41 (1.88%)
ldbc_snb_is q32 10.91 10.45 0.46 (4.36%)
ldbc_snb_is q33 97.30 97.68 -0.38 (-0.39%)
ldbc_snb_is q34 94.92 100.30 -5.37 (-5.36%)
multi-rel multi-rel-large-scan 2989.32 3314.84 -325.52 (-9.82%)
multi-rel multi-rel-lookup 75.17 68.64 6.53 (9.51%)
multi-rel multi-rel-small-scan 74.63 63.62 11.01 (17.31%)
order_by q25 168.57 167.54 1.03 (0.62%)
order_by q26 480.89 481.10 -0.21 (-0.04%)
order_by q27 1436.88 1433.55 3.33 (0.23%)
scan_after_filter q01 204.87 206.03 -1.17 (-0.57%)
scan_after_filter q02 193.52 192.86 0.67 (0.35%)
shortest_path_ldbc100 q39 129.74 49.94 79.80 (159.78%)
var_size_expr_evaluator q03 2087.00 2087.26 -0.26 (-0.01%)
var_size_expr_evaluator q04 2245.27 2216.95 28.32 (1.28%)
var_size_expr_evaluator q05 2559.82 2698.60 -138.78 (-5.14%)
var_size_expr_evaluator q06 1375.44 1360.22 15.21 (1.12%)
var_size_seq_scan q19 1498.49 1489.14 9.36 (0.63%)
var_size_seq_scan q20 3170.26 3236.33 -66.07 (-2.04%)
var_size_seq_scan q21 2432.18 2455.67 -23.49 (-0.96%)
var_size_seq_scan q22 138.81 136.27 2.54 (1.86%)

@andyfengHKU andyfengHKU merged commit 44c04dc into master Aug 8, 2024
@andyfengHKU andyfengHKU deleted the fix-list-contains-casting branch August 8, 2024 21:16
ray6080 pushed a commit that referenced this pull request Aug 14, 2024
* Fix list contains casting on empty list

* Run clang-format

---------

Co-authored-by: CI Bot <andyfengHKU@users.noreply.github.com>
ted-wq-x pushed a commit to ted-wq-x/kuzu that referenced this pull request Nov 14, 2024
* Fix list contains casting on empty list

* Run clang-format

---------

Co-authored-by: CI Bot <andyfengHKU@users.noreply.github.com>
(cherry picked from commit 44c04dc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants