Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semi mask on scan node table #4050

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Fix semi mask on scan node table #4050

merged 4 commits into from
Aug 9, 2024

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Aug 9, 2024

Description

Semi mask on scan node table was not correctly turned on, this PR fixes that.

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.13%. Comparing base (83806ee) to head (0a7afcc).
Report is 1 commits behind head on master.

Files Patch % Lines
src/function/gds/shortest_paths.cpp 0.00% 2 Missing ⚠️
src/include/common/mask.h 71.42% 2 Missing ⚠️
src/processor/operator/gds_call.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4050      +/-   ##
==========================================
- Coverage   85.14%   85.13%   -0.01%     
==========================================
  Files        1297     1297              
  Lines       50599    50604       +5     
  Branches     6978     6982       +4     
==========================================
+ Hits        43082    43084       +2     
- Misses       7376     7379       +3     
  Partials      141      141              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 9, 2024

Benchmark Result

Master commit hash: 44c04dc8e659c941a3e7fd1e8510a82a1d942e0c
Branch commit hash: 487e24d3716da58e9b80612ad6a09967a3eaf046

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 685.34 687.18 -1.84 (-0.27%)
aggregation q28 11848.92 11710.91 138.01 (1.18%)
filter q14 159.25 159.15 0.10 (0.06%)
filter q15 162.21 162.50 -0.29 (-0.18%)
filter q16 333.33 337.01 -3.68 (-1.09%)
filter q17 481.37 480.72 0.65 (0.14%)
filter q18 1987.01 1962.72 24.29 (1.24%)
fixed_size_expr_evaluator q07 572.49 570.99 1.50 (0.26%)
fixed_size_expr_evaluator q08 794.34 779.69 14.66 (1.88%)
fixed_size_expr_evaluator q09 785.15 779.05 6.09 (0.78%)
fixed_size_expr_evaluator q10 272.93 273.35 -0.41 (-0.15%)
fixed_size_expr_evaluator q11 267.96 269.05 -1.09 (-0.40%)
fixed_size_expr_evaluator q12 267.12 267.08 0.04 (0.01%)
fixed_size_expr_evaluator q13 1490.80 1507.65 -16.85 (-1.12%)
fixed_size_seq_scan q23 152.09 149.53 2.56 (1.71%)
join q31 12.52 46.87 -34.35 (-73.28%)
ldbc_snb_ic q35 763.44 3624.80 -2861.36 (-78.94%)
ldbc_snb_ic q36 55.84 125.40 -69.55 (-55.47%)
ldbc_snb_is q32 9.28 10.32 -1.04 (-10.10%)
ldbc_snb_is q33 17.81 95.40 -77.59 (-81.33%)
ldbc_snb_is q34 7.31 90.91 -83.60 (-91.96%)
multi-rel multi-rel-large-scan 2892.04 2995.77 -103.74 (-3.46%)
multi-rel multi-rel-lookup 73.65 67.43 6.22 (9.23%)
multi-rel multi-rel-small-scan 71.08 56.58 14.50 (25.63%)
order_by q25 164.62 163.06 1.56 (0.96%)
order_by q26 487.93 480.25 7.68 (1.60%)
order_by q27 1427.96 1443.55 -15.60 (-1.08%)
scan_after_filter q01 204.82 205.43 -0.61 (-0.30%)
scan_after_filter q02 194.06 193.76 0.30 (0.15%)
shortest_path_ldbc100 q39 129.87 127.20 2.67 (2.10%)
var_size_expr_evaluator q03 2085.54 2098.79 -13.25 (-0.63%)
var_size_expr_evaluator q04 2293.21 2260.87 32.34 (1.43%)
var_size_expr_evaluator q05 2670.18 2571.31 98.87 (3.85%)
var_size_expr_evaluator q06 1349.33 1365.49 -16.16 (-1.18%)
var_size_seq_scan q19 1488.13 1491.76 -3.62 (-0.24%)
var_size_seq_scan q20 3173.44 3173.83 -0.39 (-0.01%)
var_size_seq_scan q21 2418.50 2435.49 -16.99 (-0.70%)
var_size_seq_scan q22 136.43 139.10 -2.66 (-1.91%)

Copy link

github-actions bot commented Aug 9, 2024

Benchmark Result

Master commit hash: 44c04dc8e659c941a3e7fd1e8510a82a1d942e0c
Branch commit hash: 3c8b9327b2faae96041441fa7bd2f989c0ae9cfc

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 678.46 687.18 -8.72 (-1.27%)
aggregation q28 12064.51 11710.91 353.60 (3.02%)
filter q14 161.25 159.15 2.10 (1.32%)
filter q15 154.52 162.50 -7.98 (-4.91%)
filter q16 339.18 337.01 2.17 (0.64%)
filter q17 492.20 480.72 11.48 (2.39%)
filter q18 1949.44 1962.72 -13.28 (-0.68%)
fixed_size_expr_evaluator q07 565.80 570.99 -5.18 (-0.91%)
fixed_size_expr_evaluator q08 787.98 779.69 8.29 (1.06%)
fixed_size_expr_evaluator q09 780.04 779.05 0.99 (0.13%)
fixed_size_expr_evaluator q10 268.97 273.35 -4.38 (-1.60%)
fixed_size_expr_evaluator q11 262.54 269.05 -6.51 (-2.42%)
fixed_size_expr_evaluator q12 261.06 267.08 -6.02 (-2.25%)
fixed_size_expr_evaluator q13 1490.77 1507.65 -16.88 (-1.12%)
fixed_size_seq_scan q23 142.86 149.53 -6.67 (-4.46%)
join q31 12.60 46.87 -34.28 (-73.12%)
ldbc_snb_ic q35 778.16 3624.80 -2846.65 (-78.53%)
ldbc_snb_ic q36 46.60 125.40 -78.80 (-62.84%)
ldbc_snb_is q32 10.49 10.32 0.17 (1.61%)
ldbc_snb_is q33 18.03 95.40 -77.36 (-81.09%)
ldbc_snb_is q34 8.49 90.91 -82.42 (-90.66%)
multi-rel multi-rel-large-scan 2929.28 2995.77 -66.49 (-2.22%)
multi-rel multi-rel-lookup 62.94 67.43 -4.48 (-6.65%)
multi-rel multi-rel-small-scan 62.53 56.58 5.95 (10.51%)
order_by q25 158.83 163.06 -4.23 (-2.60%)
order_by q26 481.23 480.25 0.98 (0.20%)
order_by q27 1413.43 1443.55 -30.12 (-2.09%)
scan_after_filter q01 200.64 205.43 -4.79 (-2.33%)
scan_after_filter q02 185.99 193.76 -7.77 (-4.01%)
shortest_path_ldbc100 q39 128.61 127.20 1.42 (1.11%)
var_size_expr_evaluator q03 2087.66 2098.79 -11.13 (-0.53%)
var_size_expr_evaluator q04 2227.90 2260.87 -32.97 (-1.46%)
var_size_expr_evaluator q05 2631.14 2571.31 59.83 (2.33%)
var_size_expr_evaluator q06 1340.52 1365.49 -24.97 (-1.83%)
var_size_seq_scan q19 1481.88 1491.76 -9.88 (-0.66%)
var_size_seq_scan q20 3178.25 3173.83 4.42 (0.14%)
var_size_seq_scan q21 2408.01 2435.49 -27.49 (-1.13%)
var_size_seq_scan q22 132.14 139.10 -6.95 (-5.00%)

@ray6080 ray6080 merged commit 72944e9 into master Aug 9, 2024
@ray6080 ray6080 deleted the fix-semi-mask branch August 9, 2024 04:52
ray6080 added a commit that referenced this pull request Aug 14, 2024
* enable semi mask on node table

* add todo

* Add fine-grained-semi-mask optimizer

* Run clang-format

---------

Co-authored-by: xiyang <x74feng@uwaterloo.ca>
Co-authored-by: CI Bot <ray6080@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants