-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize catalog access #4058
Merged
Merged
Optimize catalog access #4058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultMaster commit hash:
|
ray6080
approved these changes
Aug 12, 2024
andyfengHKU
force-pushed
the
optimize-catalog-access
branch
from
August 12, 2024 17:53
f116668
to
4108994
Compare
Benchmark ResultMaster commit hash:
|
ray6080
pushed a commit
that referenced
this pull request
Aug 14, 2024
* Optimzie catalog access when binding query pattern * Run clang-format --------- Co-authored-by: CI Bot <andyfengHKU@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
getTableCatalogEntry
API in the catalog is introducing noticeable overhead when binding large query graph since we now need to check different versions of entry under MVCC.This PR directly save
TableCatalogEntry*
in node/rel expression instead oftableID
to avoid repeated access of catalog entries.Fixes # (issue)
Contributor agreement