Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug when intersecting an empty build side table #4089

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Aug 15, 2024

Description

Fix a case where we try to probe empty table in WCOJ

Fixes # (issue)

Contributor agreement

Copy link

Benchmark Result

Master commit hash: 2067ffa9068278551c4ac3f2816b07448192b2b8
Branch commit hash: f99dd9a0c9f7e20bd79e220691f7d67d8581d8d7

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 667.94 668.46 -0.52 (-0.08%)
aggregation q28 11324.98 11415.80 -90.82 (-0.80%)
filter q14 142.07 141.63 0.44 (0.31%)
filter q15 143.60 143.66 -0.06 (-0.04%)
filter q16 319.75 320.88 -1.13 (-0.35%)
filter q17 465.36 466.07 -0.71 (-0.15%)
filter q18 1987.72 1956.05 31.67 (1.62%)
fixed_size_expr_evaluator q07 559.92 554.50 5.42 (0.98%)
fixed_size_expr_evaluator q08 767.34 764.92 2.42 (0.32%)
fixed_size_expr_evaluator q09 772.86 765.04 7.82 (1.02%)
fixed_size_expr_evaluator q10 259.26 256.04 3.23 (1.26%)
fixed_size_expr_evaluator q11 254.44 251.09 3.35 (1.33%)
fixed_size_expr_evaluator q12 250.07 251.67 -1.60 (-0.64%)
fixed_size_expr_evaluator q13 1483.11 1486.70 -3.59 (-0.24%)
fixed_size_seq_scan q23 135.94 135.01 0.93 (0.69%)
join q31 11.99 12.16 -0.17 (-1.39%)
ldbc_snb_ic q35 772.61 737.81 34.81 (4.72%)
ldbc_snb_ic q36 48.71 48.04 0.67 (1.40%)
ldbc_snb_is q32 9.41 9.09 0.32 (3.48%)
ldbc_snb_is q33 13.73 15.11 -1.38 (-9.15%)
ldbc_snb_is q34 8.44 8.58 -0.14 (-1.67%)
multi-rel multi-rel-large-scan 3793.33 2933.05 860.28 (29.33%)
multi-rel multi-rel-lookup 72.92 79.63 -6.71 (-8.42%)
multi-rel multi-rel-small-scan 63.66 55.06 8.60 (15.62%)
order_by q25 148.04 150.81 -2.78 (-1.84%)
order_by q26 463.21 463.12 0.09 (0.02%)
order_by q27 1415.41 1425.97 -10.56 (-0.74%)
scan_after_filter q01 192.01 191.76 0.25 (0.13%)
scan_after_filter q02 179.29 180.35 -1.07 (-0.59%)
shortest_path_ldbc100 q39 48.67 48.83 -0.16 (-0.32%)
var_size_expr_evaluator q03 2064.98 2071.18 -6.20 (-0.30%)
var_size_expr_evaluator q04 2264.05 2284.48 -20.42 (-0.89%)
var_size_expr_evaluator q05 2626.24 2645.99 -19.74 (-0.75%)
var_size_expr_evaluator q06 1333.81 1338.28 -4.46 (-0.33%)
var_size_seq_scan q19 1490.91 1487.80 3.11 (0.21%)
var_size_seq_scan q20 3142.75 3216.82 -74.07 (-2.30%)
var_size_seq_scan q21 2411.18 2408.83 2.35 (0.10%)
var_size_seq_scan q22 133.24 132.84 0.40 (0.30%)

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.89%. Comparing base (2067ffa) to head (82ed026).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4089      +/-   ##
==========================================
- Coverage   83.90%   83.89%   -0.01%     
==========================================
  Files        1304     1304              
  Lines       51350    51354       +4     
  Branches     7142     7141       -1     
==========================================
  Hits        43086    43086              
- Misses       8118     8122       +4     
  Partials      146      146              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mewim mewim merged commit 5590bca into master Aug 15, 2024
23 checks passed
@mewim mewim deleted the fix-intersect-empty-table branch August 15, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants