Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Compiling with clang 14 on Ubuntu was failing with the following error: ```bash $ CXX=clang++ CC=clang ./configure --ninja $ make <snip> [7/14] LINK cctest FAILED: cctest clang++ <snip> /usr/bin/ld: obj/src/inspector/libnode.node_string.o: in function `node::inspector::protocol::StringUtil::StringViewToUtf8[abi:cxx11](v8_inspector::StringView)': node_string.cc:(.text+0x2ce): undefined reference to `node::MaybeStackBuffer<char, 1024ul>::AllocateSufficientStorage(unsigned long)' /usr/bin/ld: obj/src/inspector/libnode.node_string.o: in function `node::inspector::protocol::StringUtil::fromUTF16[abi:cxx11](unsigned short const*, unsigned long)': node_string.cc:(.text+0xad9): undefined reference to `node::MaybeStackBuffer<char, 1024ul>::AllocateSufficientStorage(unsigned long)' clang: error: linker command failed with exit code 1 (use -v to see invocation) ``` I bisected it to the referenced PR. This change includes the header file which defines `node::MaybeStackBuffer::AllocateSufficientStorage`. Refs: nodejs#46817
- Loading branch information