-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TransferEngine] Refactor code to hide transport logics from user APIs #51
[TransferEngine] Refactor code to hide transport logics from user APIs #51
Conversation
Awesome, glad to see this happen. |
Co-authored-by: doujiang24 <doujiang24@gmail.com>
int index = 0; | ||
for (auto &entry : local_topology_.getHcaList()) { | ||
if (entry == local_nic_name) { | ||
context = context_list_[index]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add break
after this line would be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, lgtm~
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have run some verification tests. Except for metadata_server
will be configured to etcd
by default when no prefix is given, other changes LGTM.
I will propose a PR to modify the related part in the vllm integration doc later.
This PR refactors the code of TransferEngine, so that the following methods are implemented by
TransferEngine
, i.e., users do not need to obtainTransport
pointers beforing calling these methods. This also enables using multiple transports (e.g.,rdma
andshm
) in the same transfer batch.We also extract metadata drivers (etcd/redis/http) seperately. User can fill the metadata server parameters with
etcd://
,redis://
orhttp://
respectively.This patch introduces major modification to TransferEngine, and still WIP.
Update on 2024/12/30: We add a patch to extract topology logics outside rdma transport, so that it can be used for other transports/medias