Allow customisation of timelines' event views' frame #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this way users can customise the layout of events displayed on the timeline currently only the event view's frame can be customised
to match upstream style
|
Thank you for the PR🙂. I'll look later today 😉 |
|
looks good, thx for your work |
kvyatkovskys
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the timelines' calculation of event view frames.
This enables the user of the library to define custom logic for positioning / sizing event views.
The use-case for me to implement this is to support "background" events which appear behind other events displayed by the timeline, which was not possible with the original implementation of
TimelineView.TimelineStylenow has an additional propertypublic var eventLayout: TimelineEventLayout = DefaultTimelineEventLayout()TimelineViewnow has an additional propertyprivate(set) var eventLayout: TimelineEventLayout, which will be set tostyle.eventLayouton init.As you might have noticed, the original behaviour is now encapsulated within
DefaultTimelineEventLayout.Let me know what you think of this.