Add event without .move
#352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `style.event.states` does not contain `.move`, it allows adding events where the user long presses, instead of adding the event to the front.
kvyatkovskys
previously approved these changes
Jun 7, 2024
Can you add a property, pls? |
No problem, I'll add it next week |
|
@kvyatkovskys I added the new style property and can now start the review again. |
kvyatkovskys
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
style.event.statesdoes not contain.move, this pr allows adding events where the user long presses, instead of adding the event to the front.I didn't add a property in
Styleto control this behavior, because I think adding an event at the finger long press is in line with common sense of interaction.If there is a need to add a control property, I can add it.