Fix the issue where the timeline.startHour was ignored
#353
Conversation
| @@ -728,7 +728,7 @@ extension TimelineView: EventDelegate { | |||
| let firstY = time.frame.origin.y - (calculatedTimeY + style.timeline.heightTime) | |||
| let percent = (pointY - firstY) / (calculatedTimeY + style.timeline.heightTime) | |||
| let newMinute = Int(60.0 * percent) | |||
| let newHour = time.tag - 1 | |||
| let newHour = time.tag - 1 + style.timeline.startHour | |||
There was a problem hiding this comment.
Hmm, did you test this case? 🤔
There was a problem hiding this comment.
Hmm, did you test this case? 🤔
Yes, I have tested it.
Logically speaking, as shown in the code below, the time tag starts at 0, which does not really reflect the time corresponding to the label.
I still don't understand why the above code needs to subtract start. Because the time tag is used in many places, I used a method with less impact, as shown in this PR.
Perhaps after understanding the above reasons for modification, you will have a more correct way to modify it.
There was a problem hiding this comment.
My current testing is not comprehensive, but I will be able to do some more comprehensive testing next week. Based on my current test results, there is nothing wrong with this modification.
There was a problem hiding this comment.
I'll check this case before merging. Thanks for your explanation 👍🏻
There was a problem hiding this comment.
@kvyatkovskys I have tested it in my project and it is necessary
If the user sets a
timeline.startHour, the event's start time should be shifted backwards.