Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move common image files to pcl/io/ during the installation; fix block alignments. #7

Merged
merged 1 commit into from
Mar 7, 2014

Conversation

fralik
Copy link

@fralik fralik commented Mar 6, 2014

This is related to issue #6 and some comments you got on PointCloudLibrary#276. It installs common image* files in pcl/io.

Also fixed alignment of blocks inside CMakeLists.txt and replaced TAB characters by spaces.

@kwaegel
Copy link
Owner

kwaegel commented Mar 6, 2014

You changed the line
PCL_ADD_INCLUDES("${SUBSYS_NAME}" "${SUBSYS_NAME}/openni2" ${OPENNI2_INCLUDES})
to
PCL_ADD_INCLUDES("${SUBSYS_NAME}" "${SUBSYS_NAME}/openni2_camera" ${OPENNI2_INCLUDES})
when the source folder is still io/openni. Is this going to cause problems?

The Travis CI build failed, but it looks like an internal compiler error and not related to your changes.

@fralik
Copy link
Author

fralik commented Mar 6, 2014

That's the opposite: I changed from openni2_camera to openni2. This deals with how files are installed. This is exactly the first comment of issue #6

As for the Travis CI I also could not connect the failure with my changes.

kwaegel pushed a commit that referenced this pull request Mar 7, 2014
Move common image files to pcl/io/ during the installation; fix block alignments.
@kwaegel kwaegel merged commit 50d493f into kwaegel:openni2_pullrequest Mar 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants