rpc: test cors, and respect option on rest endpoints #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds unit tests to the
jsonrpcserver to ensure the http mux and middleware stack handle CORS correctly, acceptingOPTIONSrequests if the server has cors enabled. The test also cover some basic json-rpc method handling behavior.A second commit updates
internal/version/version.goto reportv0.9.2-pre. We have taggedv0.9.1, and using the branch on a commit past that tag would ideally report a build from a "prerelease" revision of the next sequential version, which would bev0.9.2. I normally don't bother to bump batch version ahead of time like this, but I think it makes sense.