Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use go workspace mode everywhere #1059

Merged
merged 2 commits into from
Oct 4, 2024
Merged

use go workspace mode everywhere #1059

merged 2 commits into from
Oct 4, 2024

Conversation

jchappelow
Copy link
Member

Use Go workspace mode everywhere (no more need for replace statements in go.mod files).

Resolves #1048

@jchappelow jchappelow mentioned this pull request Oct 3, 2024
Merged
@jchappelow jchappelow changed the title [WIP] use go workspace mode everywhere use go workspace mode everywhere Oct 3, 2024
@jchappelow
Copy link
Member Author

Whatever workspace issues we had before seem to be gone now @Yaiba

@jchappelow jchappelow requested a review from Yaiba October 3, 2024 21:34
Yaiba
Yaiba approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@Yaiba Yaiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jchappelow jchappelow merged commit c9fa8f0 into kwilteam:main Oct 4, 2024
2 checks passed
@jchappelow jchappelow deleted the gowork-everywhere branch October 4, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yaiba Yaiba Yaiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get CI and all build scripts using Go workspace mode so we never need replaces in go.mod
2 participants
@jchappelow @Yaiba