Expose TrustPeriod flag for snapshots #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charithabandi
force-pushed
the
statesync-flags
branch
from
20df812
to
8bec86f
Compare
jchappelow
previously approved these changes
Oct 7, 2024
| @@ -768,20 +768,30 @@ func buildStatesyncer(d *coreDependencies, db sql.ReadTxMaker) *statesync.StateS | |||
|
|
|||
| providers := strings.Split(d.cfg.ChainConfig.StateSync.RPCServers, ",") | |||
|
|
|||
| if len(providers) == 0 { | |||
| if len(providers) == 0 || d.cfg.ChainConfig.StateSync.RPCServers == "" { | |||
There was a problem hiding this comment.
Oh good catch. I'm not sure how it would ever be len(providers) == 0, but might as well keep that.
|
@charithabandi seems to be a lint issue |
jchappelow
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.