Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] CI: try kgw test on main branch update #626

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

Yaiba
Copy link
Contributor

@Yaiba Yaiba commented Apr 2, 2024

As there are:

  • permission issue running kgw test in PRs from forked branch
  • privacy/security issue since kgw is private repo

Running kgw test on main branch seems a way to do it, as by the time it's merged to main, it's reviewed. And also (seems) no permission issue.

The main workflow tries to load the kwild image from cache built from ci workflow, then build kgw image and run only the kgw integration tests.

I'm doing experimenting rn. Not ready for review yet.

@Yaiba Yaiba changed the title [WIP] CI: try try kgw test on main branch update [WIP] CI: try kgw test on main branch update Apr 2, 2024
@Yaiba
Copy link
Contributor Author

Yaiba commented Apr 3, 2024

It contains 4 new workflows:

  • on main branch update, in main.yaml
  • on new release, in relese.yaml
  • auto trigger after 'CI' workflow success, in trigger-test-kgw.yaml
  • manual trigger, in manual-test-kgw.yaml

NOTE: trigger-test-kgw.yaml, manual-test-kgw.yaml, main.yaml use the kgw-test-reuse.yaml

- main branch update
- new release
- auto trigger after 'CI' workflow success
- manual trigger
Copy link
Member

@jchappelow jchappelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool way to have a reusable template.

@Yaiba Yaiba merged commit 5fce73f into main Apr 3, 2024
1 check passed
@Yaiba Yaiba deleted the ci/kgw-test-on-main branch April 3, 2024 18:37
@jchappelow jchappelow added this to the v0.8.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants