Actualize ConsumerTopic, KafkaConsumer, KafkaConsumerTopic, Message #46
Conversation
stubs/RdKafka/KafkaConsumer.php
Outdated
| * @param string $topic_name | ||
| * @param TopicConf $topic_conf | ||
| * | ||
| * @return Topic |
There was a problem hiding this comment.
I'm wondering if we should be more specific here. The docs say:
"Returns a RdKafka\ConsumerTopic."
https://arnaud.le-blanc.net/php-rdkafka-doc/phpdoc/rdkafka-kafkaconsumer.newtopic.html
There was a problem hiding this comment.
@kwn yep, thats my mistake, it should by KafkaConsumerTopic according to this https://github.com/arnaud-lb/php-rdkafka/blob/6.x/kafka_consumer.stub.php#L52
| * @param TopicPartition[] $topic_partitions | ||
| * @return TopicPartition[] | ||
| */ | ||
| public function pausePartitions($topic_partitions) |
There was a problem hiding this comment.
I couldn't find it in the docs:
https://arnaud.le-blanc.net/php-rdkafka-doc/phpdoc/class.rdkafka-kafkaconsumer.html
Is that something that was introduced recently and the official docs hasn't been updated yet?
There was a problem hiding this comment.
@kwn yep, it is in stub from base repo - https://github.com/arnaud-lb/php-rdkafka/blob/6.x/kafka_consumer.stub.php
| * @param TopicPartition[] $topic_partitions | ||
| * @return TopicPartition[] | ||
| */ | ||
| public function resumePartitions($topic_partitions) |
There was a problem hiding this comment.
|
Thanks @tony-sol. Released in 2.2.1. |
Actualize ConsumerTopic, KafkaConsumer, KafkaConsumerTopic, Message due to original stubs from https://github.com/arnaud-lb/php-rdkafka and doc from https://arnaud.le-blanc.net/php-rdkafka-doc/phpdoc/book.rdkafka.html