Fix bug with table-arrows when class not applied.

kyle-wannacott · Nov 8, 2024 · f2ca1c7 · f2ca1c7
1 parent 33deb6d
commit f2ca1c7
Show file tree

Hide file tree

Showing 10 changed files with 8 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -54,7 +54,7 @@ Examples on using table-sort-js with frontend frameworks such as [React.js](http
 | &lt;table&gt; classes | Description                                                                                                  |
 | --------------------- | ------------------------------------------------------------------------------------------------------------ |
 | "table-sort"          | Make the table sortable! (Words, numbers, dates, file sizes)...                                              |
-| "table-arrows"        | Display ascending or descending arrows. Supports custom arrows; example: "table-arrows-👆🤙👇"               |
+| "table-arrows"        | Display ascending or descending arrows. Supports custom arrows; for example: "table-arrows-⇈⇋⇊"              |
 | "no-class-infer"      | Turns off inference for adding sort classes automatically e.g (file-size-sort, dates-dmy-sort), etc.         |
 | "remember-sort"       | If clicking on different columns remembers sort of the original column.                                      |
 | "cells-sort"          | sort cells (td) rather than table rows (tr); useful for keeping table rows with classes/attributes in place. |

diff --git a/browser-extensions/chrome/table-sort-js.zip b/browser-extensions/chrome/table-sort-js.zip
diff --git a/browser-extensions/chrome/table-sort.js b/browser-extensions/chrome/table-sort.js
@@ -400,7 +400,7 @@ function tableSortJs(testingTableSortJS = false, domDocumentWindow = document) {
     }
 
     function changeArrowAndSort(arrowDirection, sortDirection) {
-      if (table.hasClass.tableArrows) {
+      if (table.hasClass.tableArrows[0]) {
         clearArrows(arrow);
         th.insertAdjacentText("beforeend", arrowDirection);
       }

diff --git a/browser-extensions/firefox/table-sort-js.zip b/browser-extensions/firefox/table-sort-js.zip
diff --git a/browser-extensions/firefox/table-sort.js b/browser-extensions/firefox/table-sort.js
@@ -400,7 +400,7 @@ function tableSortJs(testingTableSortJS = false, domDocumentWindow = document) {
     }
 
     function changeArrowAndSort(arrowDirection, sortDirection) {
-      if (table.hasClass.tableArrows) {
+      if (table.hasClass.tableArrows[0]) {
         clearArrows(arrow);
         th.insertAdjacentText("beforeend", arrowDirection);
       }

diff --git a/npm/README.md b/npm/README.md
@@ -54,7 +54,7 @@ Examples on using table-sort-js with frontend frameworks such as [React.js](http
 | &lt;table&gt; classes | Description                                                                                                  |
 | --------------------- | ------------------------------------------------------------------------------------------------------------ |
 | "table-sort"          | Make the table sortable! (Words, numbers, dates, file sizes)...                                              |
-| "table-arrows"        | Display ascending or descending arrows. Supports custom arrows; example: "table-arrows-👆🤙👇"               |
+| "table-arrows"        | Display ascending or descending arrows. Supports custom arrows; for example: "table-arrows-⇈⇋⇊"              |
 | "no-class-infer"      | Turns off inference for adding sort classes automatically e.g (file-size-sort, dates-dmy-sort), etc.         |
 | "remember-sort"       | If clicking on different columns remembers sort of the original column.                                      |
 | "cells-sort"          | sort cells (td) rather than table rows (tr); useful for keeping table rows with classes/attributes in place. |

diff --git a/npm/package.json b/npm/package.json
@@ -1,6 +1,6 @@
 {
   "name": "table-sort-js",
-  "version": "1.22.0",
+  "version": "1.22.1",
   "description": "A JavaScript client-side HTML table sorting library with no dependencies required.",
   "license": "MIT",
   "repository": "LeeWannacott/table-sort-js",

diff --git a/npm/table-sort.js b/npm/table-sort.js
@@ -400,7 +400,7 @@ function tableSortJs(testingTableSortJS = false, domDocumentWindow = document) {
     }
 
     function changeArrowAndSort(arrowDirection, sortDirection) {
-      if (table.hasClass.tableArrows) {
+      if (table.hasClass.tableArrows[0]) {
         clearArrows(arrow);
         th.insertAdjacentText("beforeend", arrowDirection);
       }

diff --git a/public/index.html b/public/index.html
@@ -8,7 +8,7 @@
 
     <h1>Manual testing of table sort js</h1>
     <!--  -->
-    <table class="table-sort table-arrows-👆🤙👇">
+    <table class="table-sort table-arrows-⇈⇋⇊">
         <tr>
           <td>Last Name</td>
           <td>First Name</td>

diff --git a/public/table-sort.js b/public/table-sort.js
@@ -400,7 +400,7 @@ function tableSortJs(testingTableSortJS = false, domDocumentWindow = document) {
     }
 
     function changeArrowAndSort(arrowDirection, sortDirection) {
-      if (table.hasClass.tableArrows) {
+      if (table.hasClass.tableArrows[0]) {
         clearArrows(arrow);
         th.insertAdjacentText("beforeend", arrowDirection);
       }