Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix macOS wheel build #41

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

pypae
Copy link
Contributor

@pypae pypae commented Aug 23, 2024

Follow up of #37.

Note: Somehow I can't run the workflows locally anymore, so this is kind of a shot in the dark.

  • Try to add glm to the path. I needed to do that locally, so this might also work on the runner.
  • Use macos-13 instead of macos-latest, because macos-latest uses M1 processors and I'm not sure if x86 wheels can be built.

@kylebarron
Copy link
Owner

Can you temporarily set the yaml to

# Only run on new tags starting with `v`
on:
  push:

so that we can test the wheel building on this branch?

@kylebarron
Copy link
Owner

I guess since I don't check for a tag, you should also comment out the release part while testing on this branch

@kylebarron
Copy link
Owner

I'm not sure why but the wheels aren't building on CI in this PR. Are the actions running on your fork?

@pypae
Copy link
Contributor Author

pypae commented Aug 26, 2024

Yes they are running here 👍

@pypae
Copy link
Contributor Author

pypae commented Aug 26, 2024

The build seems to be successful, so I reverted the temporary changes.

@kylebarron kylebarron merged commit 49ffad7 into kylebarron:master Aug 26, 2024
1 check passed
@kylebarron
Copy link
Owner

Ok, I force pushed the v0.2.8 tag again, so wheels are attempting to build from main now

@kylebarron
Copy link
Owner

Looks like 0.2.8 is on pypi: https://pypi.org/project/pydelatin/0.2.8/#files

Can you try that out?

@pypae
Copy link
Contributor Author

pypae commented Aug 26, 2024

Works great, thank you!

pip install --no-cache pydelatin
Collecting pydelatin
  Downloading pydelatin-0.2.8-cp312-cp312-macosx_11_0_arm64.whl.metadata (8.9 kB)
Requirement already satisfied: numpy in /Users/patrick/Library/Application Support/hatch/env/virtual/off-grid/iGlVZ8gk/off-grid/lib/python3.12/site-packages (from pydelatin) (2.1.0)
Downloading pydelatin-0.2.8-cp312-cp312-macosx_11_0_arm64.whl (170 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 171.0/171.0 kB 4.1 MB/s eta 0:00:00
Installing collected packages: pydelatin
Successfully installed pydelatin-0.2.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants