Create id-national.php

[stephanus-tantiono]

Fix #125

[kylekatarnls]

Hello, I see a very different list:

Here:
https://www.timeanddate.com/holidays/indonesia/2024?hol=1

And here:
https://en.wikipedia.org/wiki/Public_holidays_in_Indonesia

Can you provide your source?

Also if there are dates based on non-Gregorian calendars, we may add keywords to support them, for instance we did:
https://github.com/kylekatarnls/business-day/blob/master/src/Cmixin/Holidays/tz-national.php#L17

[stephanus-tantiono]

for now I only add holidays that got fixed date,will add more later

…

On Wed, 26 Jun 2024, 18:16 Kyle, ***@***.***> wrote: Hello, I see a very different list: Here: https://www.timeanddate.com/holidays/indonesia/2024?hol=1 And here: https://en.wikipedia.org/wiki/Public_holidays_in_Indonesia Can you provide your source? Also if there are dates based on non-Gregorian calendars, we may add keywords to support them, for instance we did: https://github.com/kylekatarnls/business-day/blob/master/src/Cmixin/Holidays/tz-national.php#L17 — Reply to this email directly, view it on GitHub <#129 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMM7VMKE3LCBVWSBJP4HEN3ZJKPKJAVCNFSM6AAAAABJ5QUJ4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJRGQ2DCNZYHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[ziming]

i think the holidays that are not fixed dates can be kinda hard, because some are based on the moon. Is there a good way to define them? like 1st full moon in month of october or something.etc

https://en.wikipedia.org/wiki/Lunar_phase

https://en.wikipedia.org/wiki/Lunisolar_calendar

[kylekatarnls]

Hello, we have '= chinese 01-01' which is Chinese New Year, internal it's using our LunarCalendar class to convert the date from lunisolar to gregorian.

So the same syntax could be used to define any lunisolar date.

At the moment the keywords for lunisolar can be either chinese, vietnamese or korean, it's legacy and they all are just aliases, but it would be probably make more sense semantically to just add lunisolar as a generic keyword.