Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace render table lib #2344

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Replace render table lib #2344

merged 2 commits into from
Feb 19, 2025

Conversation

pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Feb 12, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • replace lib that allows us to render tables (the previous one was too restrictive) to the jedib0t/go-pretty
  • improve kyma alpha <resource> get command to print namespace optionally only if user use the -A flag
  • add the -n shorthand for the --namespace flag

Related issue(s)

@pPrecel pPrecel added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 12, 2025
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 12, 2025
@pPrecel pPrecel force-pushed the replace-render-table-lib branch from 65eb9c6 to 5b63fea Compare February 13, 2025 08:46
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 13, 2025
@pPrecel pPrecel marked this pull request as ready for review February 13, 2025 08:47
@pPrecel pPrecel requested a review from a team as a code owner February 13, 2025 08:47
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2025
@pPrecel pPrecel added area/cli Related to all activities around CLI kind/enhancement labels Feb 13, 2025
@pPrecel pPrecel enabled auto-merge (squash) February 13, 2025 09:03
@pPrecel pPrecel merged commit fe38472 into kyma-project:main Feb 19, 2025
4 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoipm anoipm anoipm approved these changes

Assignees

@anoipm anoipm

Labels
area/cli Related to all activities around CLI cla: yes Indicates the PR's author has signed the CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/enhancement lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pPrecel @anoipm @kyma-bot