Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch name flag to args for create template command #2347

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Feb 13, 2025

Description

Changes proposed in this pull request:

  • remove the --name flag and replace it with the required argument
  • add examples displayed as --help output

Related issue(s)

@pPrecel pPrecel added area/cli Related to all activities around CLI kind/enhancement labels Feb 13, 2025
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 13, 2025
@pPrecel pPrecel force-pushed the switch-name-flag-to-args-create branch 2 times, most recently from c80c47d to f6b1c16 Compare February 19, 2025 11:22
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 19, 2025
@pPrecel pPrecel force-pushed the switch-name-flag-to-args-create branch from f6b1c16 to 705da14 Compare February 19, 2025 11:22
@pPrecel pPrecel force-pushed the switch-name-flag-to-args-create branch from 705da14 to c7a8bf3 Compare February 19, 2025 11:25
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 19, 2025
@pPrecel pPrecel marked this pull request as ready for review February 19, 2025 11:26
@pPrecel pPrecel requested a review from a team as a code owner February 19, 2025 11:26
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2025
@pPrecel pPrecel enabled auto-merge (squash) February 19, 2025 11:26
@pPrecel pPrecel merged commit 6f2ee18 into kyma-project:main Feb 19, 2025
7 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to all activities around CLI cla: yes Indicates the PR's author has signed the CLA. kind/enhancement lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants