Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(GCP VpcPeering) updating peering to the new network implementation #680

Merged
merged 3 commits into from
Oct 3, 2024
Merged

feat(GCP VpcPeering) updating peering to the new network implementation #680

merged 3 commits into from
Oct 3, 2024

Conversation

bru-jer-work
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Network object changes
  • Improved SKR validations
  • Improved KCP tests with the new network objects

@bru-jer-work bru-jer-work requested a review from a team as a code owner October 2, 2024 11:12
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 2, 2024
dushanpantic
dushanpantic reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@dushanpantic dushanpantic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

pkg/kcp/provider/gcp/vpcpeering/state.go Outdated Show resolved Hide resolved
pkg/skr/gcpvpcpeering/createKcpRemoteNetwork.go Outdated Show resolved Hide resolved
@bru-jer-work bru-jer-work changed the title New net feat(GCP VpcPeering) new network Oct 2, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 2, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 2, 2024
@bru-jer-work bru-jer-work changed the title feat(GCP VpcPeering) new network feat(GCP VpcPeering) updating peering to the new network implementation Oct 3, 2024
@bru-jer-work bru-jer-work enabled auto-merge (squash) October 3, 2024 11:31
@bru-jer-work bru-jer-work merged commit 3d9d2e2 into kyma-project:main Oct 3, 2024
11 of 12 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 3, 2024
@bru-jer-work bru-jer-work deleted the new-net branch October 3, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dushanpantic dushanpantic dushanpantic approved these changes

Assignees

@dushanpantic dushanpantic

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bru-jer-work @dushanpantic @kyma-bot