Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unit Tests Action and Moduletemplate generation from release flow #316

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Remove Unit Tests Action and Moduletemplate generation from release flow #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2b5993
cleanup_release_flow
Cortey Dec 4, 2023
c00fa9e
remove_comment
Cortey Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/workflows/create-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,6 @@ jobs:
- name: Verify
run: ./scripts/verify-keda-status.sh ${{ github.ref_name }}

run-unit-tests:
name: Unit tests
needs: verify-head-status
uses: "./.github/workflows/run-unit-tests.yaml"

create-draft:
name: Create draft release
needs: verify-head-status
Expand Down Expand Up @@ -67,7 +62,7 @@ jobs:

publish-release:
name: Publish release
needs: [verify-head-status, create-draft, run-unit-tests]
needs: [verify-head-status, create-draft]
runs-on: ubuntu-latest

steps:
Expand Down
32 changes: 0 additions & 32 deletions .github/workflows/run-unit-tests.yaml
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions scripts/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,6 @@ MODULE_VERSION=${PULL_BASE_REF} make render-manifest
echo "Generated keda-manager.yaml:"
cat keda-manager.yaml

MODULE_VERSION=${PULL_BASE_REF} \
SEC_SCANNERS_CONFIG=${PWD}/sec-scanners-config.yaml \
make module-build

echo "Generated moduletemplate.yaml:"
cat moduletemplate.yaml

echo "Fetching releases"
CURL_RESPONSE=$(curl -w "%{http_code}" -sL \
-H "Accept: application/vnd.github+json" \
Expand All @@ -70,5 +63,4 @@ echo "Updating github release with assets"
UPLOAD_URL="https://uploads.github.com/repos/kyma-project/keda-manager/releases/${RELEASE_ID}/assets"

uploadFile "keda-manager.yaml" "${UPLOAD_URL}?name=keda-manager.yaml"
uploadFile "moduletemplate.yaml" "${UPLOAD_URL}?name=moduletemplate.yaml"
uploadFile "config/samples/keda-default-cr.yaml" "${UPLOAD_URL}?name=keda-default-cr.yaml"