Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable templating of function-managed resources #15282

Closed
4 tasks
kwiatekus opened this issue Aug 25, 2022 · 1 comment
Closed
4 tasks

Enable templating of function-managed resources #15282

kwiatekus opened this issue Aug 25, 2022 · 1 comment
Labels
wontfix This will not be worked on

Comments

@kwiatekus
Copy link
Contributor

kwiatekus commented Aug 25, 2022

Description
Improve API of the function spec regarding templating of the sub resources.
Current structure of function spec.template field is not enough for the new use cases that came up ( see the Reason section )

Idea

Currently, we expose the following relevant high level Spec fields:

  • Env
  • ResourceConfiguration
  • ScaleConfig
  • Replicas
  • Template (Labels)

The high level spec fields should still work.
Users who want to use advanced templating should use two following fields that will be added to the spec:

  • RuntimeTemplate
  • BuildTemplate

Those fields should be based on a modified PodTemplateSpec.
If defined they should override configuration introduced on higher level spec fields.

Sub tasks

Reason
Give Serverless users the ability to separate configuration for function deployments and build jobs.
ATM we allow only to pass on the labels and annotations to the function's runtime pod.
We could expand the functionality of the spec.template field and separate templates for pod and build job, so that:

@kwiatekus kwiatekus added this to the 2.7 milestone Aug 25, 2022
@kwiatekus kwiatekus modified the milestones: 2.7, 2.8 Sep 5, 2022
@kwiatekus kwiatekus added the Epic label Sep 8, 2022
@kwiatekus kwiatekus added 2022-Q4 and removed 2022-Q3 labels Sep 27, 2022
@kwiatekus kwiatekus removed this from the 2.8 milestone Oct 3, 2022
@kwiatekus kwiatekus added wontfix This will not be worked on and removed Epic area/serverless Issues or PRs related to serverless 2022-Q4 labels Oct 13, 2022
@kwiatekus
Copy link
Contributor Author

As function is a kind of workload using the term "template" in the spec would cause false expectation that all fields from PodTemplateSpec are configurable via function CRD.
But this is not our goal.

We dont want to confuse users of the API and pretend that we allow to fully configure the pod.
We want to enable some new features :

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant