Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect the function runtime pod template when reconciling the function's deployment #15514

Closed
kwiatekus opened this issue Sep 16, 2022 · 1 comment
Closed

Respect the function runtime pod template when reconciling the function's deployment #15514

kwiatekus opened this issue Sep 16, 2022 · 1 comment
Labels
area/serverless Issues or PRs related to serverless duplicate This issue or pull request already exists

Comments

@kwiatekus
Copy link
Contributor

kwiatekus commented Sep 16, 2022 •
edited
Loading

Description
When controlling function's runtime deployment, the definition from the respective template ( as specified in the CR ) should be taken as the source of truth.

Add Integration tests for runtime deployment reconciliation to be based on the runtime deployment template.

Reasons
We want to enable advanced templating of function's runtime pod:

Attachments

proposal
Related Issues
Part of #15282
Depends on #15499
@kwiatekus kwiatekus added the area/serverless Issues or PRs related to serverless label Sep 16, 2022
@kwiatekus kwiatekus added this to the 2.8 milestone Sep 16, 2022
This was referenced Sep 16, 2022
Closed
Closed
Closed
@kwiatekus kwiatekus changed the title Respect the function runtime pod template when reconciling the function's pod Respect the function runtime pod template when reconciling the function's deployment Sep 19, 2022
@kwiatekus
Copy link
Contributor Author

Closing in favor of #15737, #14998, #14877

@kwiatekus kwiatekus removed this from the 2.8 milestone Oct 6, 2022
@kwiatekus kwiatekus added the duplicate This issue or pull request already exists label Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/serverless Issues or PRs related to serverless duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moelsayed @kwiatekus