Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose changes in the Function CRD #15862

Merged
merged 20 commits into from
Nov 9, 2022
Merged

Propose changes in the Function CRD #15862

merged 20 commits into from
Nov 9, 2022

Conversation

kwiatekus
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Proposal for extending Function CRD

Related issue(s)
#14877
#14998
#15737

@kwiatekus kwiatekus added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2022
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 20, 2022
This was referenced Oct 21, 2022
Closed
Closed
Closed
@dbadura dbadura added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 26, 2022
@netlify
Copy link

netlify bot commented Oct 26, 2022 •
edited
Loading

✅ 🥰 Documentation preview ready! 🥰

Name Link
🔨 Latest commit 36b85ed
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/636b9927a383f500097e8cf4
😎 Deploy Preview https://deploy-preview-15862--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kwiatekus kwiatekus added architecture and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 27, 2022
moelsayed
moelsayed reviewed Oct 27, 2022
View reviewed changes
Copy link
Contributor

@moelsayed moelsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed options cover most possible permutations, so I am not going to add another one. I just added a few comments.

components/function-controller/design/extend_function_spec_proposal.md Show resolved Hide resolved
components/function-controller/design/extend_function_spec_proposal.md Outdated Show resolved Hide resolved
components/function-controller/design/extend_function_spec_proposal.md Outdated Show resolved Hide resolved
components/function-controller/design/extend_function_spec_proposal.md Outdated Show resolved Hide resolved
components/function-controller/design/extend_function_spec_proposal.md Outdated Show resolved Hide resolved
components/function-controller/design/extend_function_spec_proposal.md Show resolved Hide resolved
@kyma-bot kyma-bot removed lgtm Looks good to me! labels Oct 31, 2022
@kwiatekus kwiatekus assigned kwiatekus and unassigned pbochynski Oct 31, 2022
@dbadura dbadura self-assigned this Oct 31, 2022
kwiatekus and others added 3 commits November 3, 2022 13:11
@kwiatekus
Incorporate review feedback
ec9c2c4
@kwiatekus @dbadura
Apply suggestions from code review
744db71 
Co-authored-by: Damian Badura <45110612+dbadura@users.noreply.github.com>
@kwiatekus
Incorporate review feedback
6f8bdda
@kyma-bot
Copy link
Contributor

kyma-bot commented Nov 7, 2022

@kwiatekus: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-event-publisher-proxy-unit-test 378a7bc link true /test pull-event-publisher-proxy-unit-test
pull-eventing-controller-unit-test 378a7bc link true /test pull-eventing-controller-unit-test
pull-kyma-pjtester 6f8bdda link true /test pull-kyma-pjtester

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kwiatekus and others added 2 commits November 8, 2022 13:43
@kwiatekus @dbadura
Apply suggestions from code review
9a43b2c 
Co-authored-by: Damian Badura <45110612+dbadura@users.noreply.github.com>
@kwiatekus
changes after code review
7355bc6
@dbadura
Copy link
Contributor

dbadura commented Nov 9, 2022

Looks ok

grego952
grego952 reviewed Nov 9, 2022
View reviewed changes
components/function-controller/design/extend_function_spec_proposal.md Outdated Show resolved Hide resolved
components/function-controller/design/extend_function_spec_proposal.md Outdated Show resolved Hide resolved
components/function-controller/design/extend_function_spec_proposal.md Outdated Show resolved Hide resolved
components/function-controller/design/extend_function_spec_proposal.md Outdated Show resolved Hide resolved
components/function-controller/design/extend_function_spec_proposal.md Outdated Show resolved Hide resolved
components/function-controller/design/extend_function_spec_proposal.md Outdated Show resolved Hide resolved
components/function-controller/design/extend_function_spec_proposal.md Outdated Show resolved Hide resolved
components/function-controller/design/extend_function_spec_proposal.md Outdated Show resolved Hide resolved
components/function-controller/design/extend_function_spec_proposal.md Outdated Show resolved Hide resolved
components/function-controller/design/extend_function_spec_proposal.md Outdated Show resolved Hide resolved
@kwiatekus @grego952
Apply suggestions from code review
36b85ed 
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 9, 2022
@kwiatekus kwiatekus merged commit d61f011 into kyma-project:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moelsayed moelsayed moelsayed left review comments

@a-thaler a-thaler a-thaler left review comments

@pPrecel pPrecel pPrecel left review comments

@anoipm anoipm anoipm left review comments

@dbadura dbadura dbadura left review comments

@grego952 grego952 grego952 approved these changes

@pbochynski pbochynski pbochynski left review comments

@mmitoraj mmitoraj Awaiting requested review from mmitoraj

@majakurcius majakurcius Awaiting requested review from majakurcius

@NHingerl NHingerl Awaiting requested review from NHingerl

@IwonaLanger IwonaLanger Awaiting requested review from IwonaLanger

@anishj0shi anishj0shi Awaiting requested review from anishj0shi

@k15r k15r Awaiting requested review from k15r

Assignees

@kwiatekus kwiatekus

@dbadura dbadura

@grego952 grego952

Labels
architecture lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@kwiatekus @kyma-bot @dbadura @pbochynski @moelsayed @a-thaler @pPrecel @anoipm @grego952