Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove v1alpha1 conversion webhook #17090

Merged
merged 5 commits into from
Mar 21, 2023
Merged

Remove v1alpha1 conversion webhook #17090

merged 5 commits into from
Mar 21, 2023

Conversation

dbadura
Copy link
Contributor

@dbadura dbadura commented Mar 15, 2023

Description

Changes proposed in this pull request:

  • Remove v1alpha1 conversion webhook

Related issue(s)
#16974

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2023
@netlify
Copy link

netlify bot commented Mar 15, 2023 •
edited

✅ Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 545ee07
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/6418a08442bb4200088b511b
😎 Deploy Preview https://deploy-preview-17090--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 15, 2023
@dbadura dbadura force-pushed the remove-v1alpha1-conversion-webhook branch from b9b6061 to 83c63be Compare March 20, 2023 12:00
@dbadura
Copy link
Contributor Author

dbadura commented Mar 20, 2023

/test all

1 similar comment
@dbadura
Copy link
Contributor Author

dbadura commented Mar 20, 2023

/test all

@dbadura
Copy link
Contributor Author

dbadura commented Mar 20, 2023

/retest

@dbadura
Copy link
Contributor Author

dbadura commented Mar 20, 2023

/test all

1 similar comment
@dbadura
Copy link
Contributor Author

dbadura commented Mar 20, 2023

/test all

@dbadura
Copy link
Contributor Author

dbadura commented Mar 20, 2023

/test all

@dbadura
Copy link
Contributor Author

dbadura commented Mar 20, 2023

/test all

@dbadura
Copy link
Contributor Author

dbadura commented Mar 20, 2023

/retest

@dbadura dbadura marked this pull request as ready for review March 20, 2023 19:04
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2023
@dbadura
Copy link
Contributor Author

dbadura commented Mar 21, 2023

/test all

@dbadura
Copy link
Contributor Author

dbadura commented Mar 21, 2023

/retest

@kyma-bot
Copy link
Contributor

kyma-bot commented Mar 21, 2023 •
edited

@contributor: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-integration-k3d-runtime-agent 545ee07 link false /test pre-main-kyma-integration-k3d-runtime-agent

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 21, 2023
@kyma-bot kyma-bot merged commit c871068 into kyma-project:main Mar 21, 2023
@dbadura dbadura deleted the remove-v1alpha1-conversion-webhook branch March 22, 2023 07:49
@pbochynski pbochynski mentioned this pull request Mar 23, 2023
Closed
@a-thaler a-thaler mentioned this pull request Mar 27, 2023
Closed
@kwiatekus kwiatekus added the area/serverless Issues or PRs related to serverless label Apr 6, 2023
@kwiatekus kwiatekus added this to the 2.13 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pPrecel pPrecel pPrecel approved these changes

@m00g3n m00g3n Awaiting requested review from m00g3n

@kwiatekus kwiatekus Awaiting requested review from kwiatekus

@Cortey Cortey Awaiting requested review from Cortey

@anoipm anoipm Awaiting requested review from anoipm

Assignees

@pPrecel pPrecel

Labels
area/serverless Issues or PRs related to serverless lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
2.13
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dbadura @kyma-bot @pPrecel @kwiatekus